Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no tcp: {} option - instead spec.listeners{} in the last helm chart values #11270

Closed
shukurew opened this issue Apr 17, 2024 · 3 comments
Closed
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@shukurew
Copy link

shukurew commented Apr 17, 2024

Hi, I'm trying to expose custom TCP/UDP port using helm chart option

I pulled and installed this offical helm chart
helm pull oci://ghcr.io/nginxinc/charts/nginx-ingress --untar --version 1.2.0
cd nginx-ingress
nano values.yaml

I want add below redis to values.yaml but there is no tcp: {} option in default values.yaml (as it was in old values.yaml file)

tcp:
  6379: default/redis-service:6379
  6380: default/redis-service:6380

I noticed there is new option appeared: Is that alternative of tcp: {} option???

spec: {}
   listeners:
      - name: dns-udp
        port: 5353
        protocol: UDP
      - name: dns-tcp
        port: 5353
        protocol: TCP

I tried to add using my custom-values.yaml but still no port exposed

image

tcp:
  6379: default/redis-service:6379
controller:
  service:
    enabled: true
    ports:
      http: 80
      https: 443
      redis-service: 6379
    targetPorts:
      http: http
      https: https
      redis-service: redis-service

Is there any major update or am I doing fundamentally wrong??

Tasks

No tasks being tracked yet.
@shukurew shukurew added the kind/bug Categorizes issue or PR as related to a bug. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shukurew shukurew changed the title no tcp: {} option in the last helm chart values no tcp: {} instead spec.listeners{} option in the last helm chart values Apr 18, 2024
@shukurew shukurew changed the title no tcp: {} instead spec.listeners{} option in the last helm chart values no tcp: {} option - instead spec.listeners{} in the last helm chart values Apr 18, 2024
@longwuyuan
Copy link
Contributor

/remove-kind bug

  • The URL oci://ghcr.io/nginxinc/charts/nginx-ingress you provided is for the NGINX INC. product but this github repo is the Kubernetes Community Ingress controller

  • Names have similarities so happens often

  • Reach out in the NGINX INC. forums

/close

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

@longwuyuan: Closing this issue.

In response to this:

/remove-kind bug

  • The URL oci://ghcr.io/nginxinc/charts/nginx-ingress you provided is for the NGINX INC. product but this github repo is the Kubernetes Community Ingress controller

  • Names have similarities so happens often

  • Reach out in the NGINX INC. forums

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants