Is there any way to increase controllers post-shutdown-grace-period parameter value in helm?

[sokoow]

What happened:
I'm trying to get more than 10 seconds of grace when shutdown is invoked. I can see that there's post-shutdown-grace-period parameter, but helm chart doesn't seem to be able to change it (I may be wrong).

I thought #8095 and #8143 might help, but not much info over there either

What you expected to happen:

Find a way to change this parameter in helm chart's values.yaml

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.): v1.3.0
Kubernetes version (use kubectl version): 1.21.14-eks

[k8s-ci-robot]

@sokoow: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kundan2707]

@sokoow you can achieve graceful shutdown by adding following content in pod spec

spec:
  terminationGracePeriodSeconds: 600

[kundan2707]

/remove-kind bug

[sokoow]

@kundan2707 thanks for replying, but then what is this post-shutdown-grace-period parameter for and why it defaults to 10s?

[longwuyuan]

/remove-kind bug
/kind support

[strongjz]

ingress-nginx/pkg/flags/flags.go

Line 210 in a581a7b

postShutdownGracePeriod = flags.Int("post-shutdown-grace-period", 10, "Seconds to wait after the nginx process has stopped before controller exits.")

https://github.com/kubernetes/ingress-nginx/pull/8143/files

The option is there; I have also opened a new issue to make sure the documentation is updated #9214

If this does not fix the issue, please reopen the issue and comment. Thank you for pointing out this issue.

/close

[k8s-ci-robot]

@strongjz: Closing this issue.

In response to this:

ingress-nginx/pkg/flags/flags.go

Line 210 in a581a7b

postShutdownGracePeriod = flags.Int("post-shutdown-grace-period", 10, "Seconds to wait after the nginx process has stopped before controller exits.")

https://github.com/kubernetes/ingress-nginx/pull/8143/files

The option is there; I have also opened a new issue to make sure the documentation is updated #9214

If this does not fix the issue, please reopen the issue and comment. Thank you for pointing out this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[strongjz]

I misread the ask, here is the Helm configuration extraArgs

https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml#L180

 # -- Additional command line arguments to pass to nginx-ingress-controller
  # E.g. to specify the default SSL certificate you can use
  extraArgs: {}