-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add documentation about default ingress helm value, corrections to only ingress section #7943
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Frederik-Baetens! |
Hi @Frederik-Baetens. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also your CLA process is a bit intrusive. Requiring a physical mailing adress for all contributors seems quite excessive. I've also signed a CLA with google (also transferring IP rights), and their process was significantly smoother. Why do I even need to sign 2 separate CLA's? (one easycla and one linux foundation cla)? |
334a1bd
to
af695cb
Compare
will review the PR this week, but answering about the CLA: it's an org wide requirement (and also CNCF) and we are in the middle of migration to EasyCLA, so this is why both of them appears. About mailing, etc etc it's out of our scope of control, as we are part of the org :) |
af695cb
to
f31345a
Compare
I have rebased this pr, in doing so keeping the style changes that were committed to main. If it's desirable, i can also omit the second commit in this pr, since it's a more opinionated change. |
Also cleaned up the entire "I have only one instance of the Ingress-NGINX controller in my cluster" section
f31345a
to
b24208c
Compare
@Frederik-Baetens , would it work for you to squash your commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/priority important-soon
/kind documentation
@longwuyuan I think if we add the following label it should do it while merging, let's try :)
/label tide/merge-method-squash
@Frederik-Baetens thx
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Frederik-Baetens, iamNoah1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@longwuyuan worked |
good job @iamNoah1 |
… to only ingress section (kubernetes#7943) * add explanation about ingressClassResource.default for helm users Also cleaned up the entire "I have only one instance of the Ingress-NGINX controller in my cluster" section * docs: default ingressclass only when running one controller * fix link to what is the flag watch ingress * clarify usage of default ingress class annotation
What this PR does / why we need it:
Documentation about setting the default ingressclass annotation with helm was missing. Also this section could be interpreted as recommending setting a default ingressClass when running other ingresses besides ingress-nginx. While that is sometimes what the user wants, I don't think it's wise to recommend doing so to all users with multiple ingresses. The documentation has been changed to only recommend setting a default ingressClass when only running one ingress controller.
Types of changes
How Has This Been Tested?
I rendered the docs with mkdocs
Checklist: