reintroduce helm-docs step in ci

[longwuyuan]

helm-docs step was removed from ci.yaml so re-introducing it.

While trying to automate helm-docs in CI. But GITHUB_TOKEN failed as the committer needs to have cla-signed and GITHUB_TOKEN does not have cla-signed, and helm-docs automation requires to commit a changed /charts/ingress-nginx/README.md back into the project. Using GITHUB_TOKEN, this is the error ;

remote: error: GH006: Protected branch update failed for refs/heads/main.        
remote: error: Required status check "cla/linuxfoundation" is expected.        
To https://github.com/kubernetes/ingress-nginx.git
 ! [remote rejected]     main -> main (protected branch hook declined)
error: failed to push some refs to 'https://github.com/kubernetes/ingress-nginx.git'
Error: Process completed with exit code 1.

So now re-adding helm-docs step, only for verify, while we work on a better solution for helm-docs automation in CI.

[longwuyuan]

@rikatz @tao12345666333 @cpanato , looking for lgtm/approve on this. Thanks

[cpanato]

/triage accepted
/kind feature
/priority important-soon

[cpanato]

/lgtm

[longwuyuan]

/assign @strongjz
James, looking for approve on this

[tao12345666333]

/lgtm

BTW putting it back in, will this still be the same problem we had before the Release process?

[longwuyuan]

@tao12345666333 if the diff is not "nil", then yes

[rikatz]

/approve
/hold

Is there a way at least of giving a more user friendly error on gh actions, asking users to run helm-docs?

[longwuyuan]

We can put an bash echo statement there for now if you like.
I am more favouring your personal token or anybody else's personal token at least for now so we can get past that cla-required error

[longwuyuan]

I copied your attempted if condition from yesterday and put a echo statement there. Please check latest commit @rikatz

[rikatz]

/lgtm
/unhold
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, longwuyuan, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment