Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding user snippets to the user-data -- Perhaps a systemd unit abstraction ? #789

Closed
hsyed opened this issue Nov 2, 2016 · 9 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@hsyed
Copy link

hsyed commented Nov 2, 2016

My current use case is to mount an EFS drive on all cluster nodes. Perhaps there is support for doing this with DaemonSets -- or there is some other k8s mechanism for it. Regardless it would be nice if we could have abstractions for just verbatim appending user supplied chunks of data to the user-data scripts.

It would be fantastic if we could get some support at the level of coreos cloud-config minus the open ended and easy-to-get wrong nature of cloud-init and cloud-config.

An abstraction for supplying a directory with systemd unit files would be fantastic -- perhaps the abstraction could be made drop-in aware somehow ? All the operating systems under consideration have first class systemd support so it seems a clean and logical approach for user extension.

@hsyed hsyed changed the title More support for adding user snippets to the user-data -- Perhaps a systemd unit abstraction ? Support for adding user snippets to the user-data -- Perhaps a systemd unit abstraction ? Nov 2, 2016
@chrislovecnm
Copy link
Contributor

We are installing the base install. Bare bones. If you need CM after the fact. I encourage you to do that.

@krisnova
Copy link
Contributor

krisnova commented Nov 3, 2016

Pointing #791 and #789 to each other..

More use cases for extending kops

@justinsb
Copy link
Member

Daemonsets are the "k8s systemd unit file", so I think if we're going to support some extension mechanism, we should prefer that.

That said, I think we've agreed to support a post-boot shell-script or similar. Every time you use it an angel will lose its wings, but there will be that mechanism also.

@justinsb justinsb added this to the 1.5.1 milestone Dec 28, 2016
@mdbishop
Copy link

mdbishop commented Mar 2, 2017

Just wanted to add a vote for this. Our use case it to add system monitoring which is "unsupported" at this time running containerized so we'd like to have the agent install itself once a node is turned up. Especially with spot or preemptible's, taking this on as a one-off is untenable.

I'd be quite happy with nothing fancy -- just a bash script that could run after all the other init scripts have completed would be all I'd need. If folks had requirements more involved, the script could drop in a chef agent for instance, and (with all the caveats about not clobbering the carefully written k8s scripts) be good to go.

@sellers
Copy link
Contributor

sellers commented Jul 24, 2017

Being able to inject into the cloud-init user data would be helpful for being able to modify the results of the LC w/o having to build a custom AMI.

@KashifSaadat
Copy link
Contributor

I believe this is covered by the implementation of Hooks (https://github.com/kubernetes/kops/blob/master/docs/cluster_spec.md#hooks), but otherwise extension of the user-data scripts may be covered in PR #3633.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 16, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

9 participants