Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum Terraform version to 0.12.26/0.13.0 #10109

Merged

Conversation

bmelbourne
Copy link
Contributor

@bmelbourne bmelbourne commented Oct 26, 2020

What this PR does / why we need it:
As Terraform 0.11 is in the later stages of end-of-life (EOL), the Terraform build/test templates have been updated to be fully compatible with Terraform 0.12.26+ and 0.13.0+.

https://www.hashicorp.com/blog/deprecating-terraform-0-11-support-in-terraform-providers

Minimum Terraform AWS provider is set to v3.12.0 and Google provider is set to v3.44.0.

Which issue(s) this PR fixes
N/A

Special notes for your reviewer:
The KOPS_FEATURE_FLAGS=Terraform-0.12 will be deprecated in Kops v0.20.

Terraform reference notes regarding 0.12/0.13 provider compatibility.

https://www.terraform.io/docs/configuration/provider-requirements.html#v0-12-compatible-provider-requirements
https://www.terraform.io/upgrade-guides/0-13.html#explicit-provider-source-locations

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2020
@bmelbourne
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/addons area/api area/channels area/provider/aws Issues or PRs related to aws provider and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2020
@hakman
Copy link
Member

hakman commented Oct 27, 2020

Something's not quite right with the commits.

@bmelbourne
Copy link
Contributor Author

Something's not quite right with the commits.

It's WIP...I just needed to check the Virgin Media Web Safe settings weren't going to mess with the commits in my new branch between my forked repo and the kops upstream repo.

Just running the various tests locally and then I'll squash the commits and final rebase! 😉

@hakman
Copy link
Member

hakman commented Oct 27, 2020

Ah, cool. :)
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added area/documentation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2020
@hakman
Copy link
Member

hakman commented Oct 28, 2020

/retest

@bmelbourne
Copy link
Contributor Author

/assign @rifelpet

Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, just a couple comments.
#10101 creates the 1.20 release notes and mentions the feature flag removal but if we do end up requiring aws provider 3.X then we should probably mention that and link to the upgrade guide as well since it has additional instructions.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-3-upgrade#provider-version-configuration

docs/terraform.md Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/terraform/target_hcl2.go Outdated Show resolved Hide resolved
@rifelpet
Copy link
Member

rifelpet commented Oct 28, 2020

/lgtm
/approve

Thanks for doing this! Feel free to /hold cancel and remove WIP from the PR title to get this merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@bmelbourne
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@bmelbourne bmelbourne changed the title [WIP] Set minimum Terraform version to 0.12.26/0.13.0 Set minimum Terraform version to 0.12.26/0.13.0 Oct 29, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2020
@bmelbourne
Copy link
Contributor Author

/lgtm
/approve

Thanks for doing this! Feel free to /hold cancel and remove WIP from the PR title to get this merged.

@rifelpet thanks! 😄
I was just waiting for the CI tests to complete before removing the labels.

@k8s-ci-robot k8s-ci-robot merged commit b7f66a6 into kubernetes:master Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 29, 2020
@bmelbourne bmelbourne deleted the set-minimum-terraform-0.12 branch October 29, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/channels area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants