-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum Terraform version to 0.12.26/0.13.0 #10109
Set minimum Terraform version to 0.12.26/0.13.0 #10109
Conversation
Hi @bmelbourne. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
64f0b67
to
f552e83
Compare
Something's not quite right with the commits. |
It's WIP...I just needed to check the Virgin Media Web Safe settings weren't going to mess with the commits in my new branch between my forked repo and the kops upstream repo. Just running the various tests locally and then I'll squash the commits and final rebase! 😉 |
Ah, cool. :) |
f552e83
to
69761f2
Compare
/retest |
/assign @rifelpet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, just a couple comments.
#10101 creates the 1.20 release notes and mentions the feature flag removal but if we do end up requiring aws provider 3.X then we should probably mention that and link to the upgrade guide as well since it has additional instructions.
bc10ee2
to
84417c3
Compare
/lgtm Thanks for doing this! Feel free to |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmelbourne, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@rifelpet thanks! 😄 |
What this PR does / why we need it:
As Terraform 0.11 is in the later stages of end-of-life (EOL), the Terraform build/test templates have been updated to be fully compatible with Terraform 0.12.26+ and 0.13.0+.
https://www.hashicorp.com/blog/deprecating-terraform-0-11-support-in-terraform-providers
Minimum Terraform AWS provider is set to v3.12.0 and Google provider is set to v3.44.0.
Which issue(s) this PR fixes
N/A
Special notes for your reviewer:
The KOPS_FEATURE_FLAGS=Terraform-0.12 will be deprecated in Kops v0.20.
Terraform reference notes regarding 0.12/0.13 provider compatibility.
https://www.terraform.io/docs/configuration/provider-requirements.html#v0-12-compatible-provider-requirements
https://www.terraform.io/upgrade-guides/0-13.html#explicit-provider-source-locations