Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow attaching same external target group to multiple instance groups #10335

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Allow attaching same external target group to multiple instance groups #10335

merged 1 commit into from
Dec 3, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 1, 2020

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
rifelpet
rifelpet reviewed Dec 2, 2020
View reviewed changes
upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/network_load_balancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/network_load_balancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awsup/aws_utils.go Show resolved Hide resolved
@hakman hakman force-pushed the same-tg-multiple-igs branch 3 times, most recently from 15e64e7 to e744d78 Compare December 2, 2020 07:02
@hakman hakman changed the title [WIP] Allow attaching same external target group to multiple instance groups Allow attaching same external target group to multiple instance groups Dec 2, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
olemarkus
olemarkus approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet
Copy link
Member

rifelpet commented Dec 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@hakman hakman mentioned this pull request Dec 3, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit 1b45f87 into kubernetes:master Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 3, 2020
@hakman hakman deleted the same-tg-multiple-igs branch December 3, 2020 05:53
k8s-ci-robot added a commit that referenced this pull request Dec 4, 2020
@k8s-ci-robot
Merge pull request #10358 from hakman/automated-cherry-pick-of-#10296-#…
e54a46e 
…10335-upstream-release-1.19

Automated cherry pick of #10296: Remove support for using legacy ELB name #10335: Allow attaching same external target group to multiple
@hakman hakman mentioned this pull request Jan 27, 2021
Merged
@hakman hakman mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@olemarkus olemarkus olemarkus approved these changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @rifelpet @olemarkus