Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom containerd socket with Flatcar #10518

Closed
wants to merge 1 commit into from

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 3, 2021

Flatar uses /run/docker/libcontainerd/docker-containerd.sock for the containerd socket as mentioned in flatcar/Flatcar#284.

This should fix the failing periodic test:
https://testgrid.k8s.io/kops-distros#kops-aws-distro-flatcar

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 3, 2021
@hakman hakman changed the title [WIP] Use custom containerd socket with Flatcar Use custom containerd socket with Flatcar Jan 3, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2021
@rifelpet
Copy link
Member

rifelpet commented Jan 4, 2021

I wonder if this was a recent Flatcar change or if Flatcar always used this socket location and our containerd+Flatcar support just never worked
/lgtm
/hold if you think we should key off of the Flatcar OS version as well, otherwise feel free to remove this.

EDIT: oh I thought GHA would run on the merged result of the PR but apparently its still failing due to the copyright year issue so you'll need to rebase regardless.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@hakman
Copy link
Member Author

hakman commented Jan 4, 2021

Thanks for the review @rifelpet. Flatcar is a rolling release, so we only care about latest.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2021
@hakman
Copy link
Member Author

hakman commented Jan 4, 2021

/hold for now, to se if there is a change of approach in Flatcar defaults

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2021
@hakman
Copy link
Member Author

hakman commented Jan 5, 2021

This was good as a test run, but seem a more permanent fix will be required:
flatcar/Flatcar#284 (comment)

@hakman
Copy link
Member Author

hakman commented Jan 6, 2021

Closing in favor of #10540.
/close

@k8s-ci-robot
Copy link
Contributor

@hakman: Closed this PR.

In response to this:

Closing in favor of #10540.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman hakman deleted the fix-containerd-flatcar branch January 10, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants