-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom containerd socket with Flatcar #10518
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
99440a1
to
7401ab0
Compare
I wonder if this was a recent Flatcar change or if Flatcar always used this socket location and our containerd+Flatcar support just never worked EDIT: oh I thought GHA would run on the merged result of the PR but apparently its still failing due to the copyright year issue so you'll need to rebase regardless. |
7401ab0
to
79010cd
Compare
New changes are detected. LGTM label has been removed. |
Thanks for the review @rifelpet. Flatcar is a rolling release, so we only care about latest. |
/hold for now, to se if there is a change of approach in Flatcar defaults |
This was good as a test run, but seem a more permanent fix will be required: |
Closing in favor of #10540. |
@hakman: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Flatar uses
/run/docker/libcontainerd/docker-containerd.sock
for the containerd socket as mentioned in flatcar/Flatcar#284.This should fix the failing periodic test:
https://testgrid.k8s.io/kops-distros#kops-aws-distro-flatcar