Refactor and centralize distribution logic #10538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/nodeup
approved
Use of a struct makes it more sustainable, centralizing into the distribution package makes it simpler to follow.
justinsb
force-pushed
the
ubuntu_2010_partii
branch
from
61272ea
to
78b1394
Compare
seh
reviewed
Jan 7, 2021
| klog.Warningf("Unknown distro; won't write kubeconfig to homedir %s", b.Distribution) | ||
| users, err := b.Distribution.DefaultUsers() | ||
| if err != nil { | ||
| klog.Warningf("won't write kubeconfig to homedir for distribution %s: %v", b.Distribution, err) |
There was a problem hiding this comment.
Will we start wrapping inner errors via the %w verb?
There was a problem hiding this comment.
I think we should yes, but annoyingly klog doesn't yet recognize it (last I checked!), so we have to use %v.
So yes for fmt.Errorf, not yet for klog
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of a struct makes it more sustainable, centralizing into the
distribution package makes it simpler to follow.