Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add azure support for internal loadbalancer to k8s api #10744

Merged
merged 1 commit into from
Feb 12, 2021
Merged

add azure support for internal loadbalancer to k8s api #10744

merged 1 commit into from
Feb 12, 2021

Conversation

collin-woodruff-t1cg
Copy link
Contributor

Creates Basic type Loadbalancer that can be used to connect to the k8s api.

Notes:

  • Kops will try to delete the loadbalancer first and receive an error but will successfully get deleted on the retry since resources are no longer using it.
  • After creating will need to use --insecure-skip-tls-verify to successfully connect to the api.

Any guidance to fix these issues would be appreciated. I'd be happy to add the fixes to my pr.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @collin-woodruff-t1cg!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @collin-woodruff-t1cg. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2021
@collin-woodruff-t1cg
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 5, 2021
@collin-woodruff-t1cg collin-woodruff-t1cg force-pushed the caw/azureLoadbalancer branch 2 times, most recently from abe0bd8 to f4c33b9 Compare February 5, 2021 17:01
@rifelpet
Copy link
Member

rifelpet commented Feb 5, 2021

/ok-to-test
/cc @kenji-cloudnatix

@k8s-ci-robot
Copy link
Contributor

@rifelpet: GitHub didn't allow me to request PR reviews from the following users: kenji-cloudnatix.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/ok-to-test
/cc @kenji-cloudnatix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2021
kenji-cloudnatix
kenji-cloudnatix reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@kenji-cloudnatix kenji-cloudnatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change, @collin-woodruff-t1cg ! I'm not very familiar with the LB logic in kops. Just made several superficial comments..

upup/pkg/fi/cloudup/azure/azure_cloud.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/loadbalancer.go Outdated Show resolved Hide resolved
pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
@collin-woodruff-t1cg collin-woodruff-t1cg force-pushed the caw/azureLoadbalancer branch 3 times, most recently from c93805c to 283c113 Compare February 5, 2021 21:20
kenji-cloudnatix
kenji-cloudnatix approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@kenji-cloudnatix kenji-cloudnatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
@collin-woodruff-t1cg collin-woodruff-t1cg force-pushed the caw/azureLoadbalancer branch 2 times, most recently from ccb4f27 to 9a6e2dd Compare February 5, 2021 22:38
rifelpet
rifelpet reviewed Feb 5, 2021
View reviewed changes
pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/vmscaleset.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azure/azure_cloud.go Show resolved Hide resolved
upup/pkg/fi/cloudup/azure/azure_cloud.go Show resolved Hide resolved
upup/pkg/fi/cloudup/azure/azure_cloud.go Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/loadbalancer.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/loadbalancer.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 8, 2021
rifelpet
rifelpet reviewed Feb 10, 2021
View reviewed changes
upup/pkg/fi/cloudup/azure/azure_cloud.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azure/azure_cloud.go Outdated Show resolved Hide resolved
pkg/model/azuremodel/api_loadbalancer.go Outdated Show resolved Hide resolved
rifelpet
rifelpet reviewed Feb 10, 2021
View reviewed changes
upup/pkg/fi/cloudup/azuretasks/vmscaleset.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/vmscaleset.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/azuretasks/vmscaleset.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 10, 2021
rifelpet
rifelpet reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry one more minor fix and then we can get this merged

upup/pkg/fi/cloudup/azuretasks/vmscaleset.go Outdated Show resolved Hide resolved
@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: collin-woodruff-t1cg, kenji-cloudnatix, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 688aeb8 into kubernetes:master Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 12, 2021
@rifelpet rifelpet mentioned this pull request Feb 12, 2021
Merged
@rifelpet rifelpet modified the milestones: v1.20, v1.21 Feb 13, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 13, 2021
@k8s-ci-robot
Merge pull request #10810 from rifelpet/automated-cherry-pick-of-#107…
54f4cd6 
…44-origin-release-1.20

Automated cherry pick of #10744: add internal loadbalancer for azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@kenji-cloudnatix kenji-cloudnatix kenji-cloudnatix approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@collin-woodruff-t1cg @k8s-ci-robot @rifelpet @kenji-cloudnatix