-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: asset task copy docker image #10767
fix: asset task copy docker image #10767
Conversation
Hi @johanneswuerbach. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rifelpet |
/ok-to-test |
Thanks for the fix, I'll see about getting this covered under e2e testing /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johanneswuerbach, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…67-origin-release-1.19 Automated cherry pick of #10767: fix: asset task copy docker image
…67-origin-release-1.20 Automated cherry pick of #10767: fix: asset task copy docker image
Otherwise
kops update cluster --name XYZ --yes --phase assets
fails with:Ideally this would be test covered, but it seems it wasn't before so I'm not sure how to test this.
This seems to have been introduced in #10193, which was back-ported to kops 1.19 were we ran into this.