-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #11674: Add support for Docker v20.10.7 #11680
Automated cherry pick of #11674: Add support for Docker v20.10.7 #11680
Conversation
The master PR didnt have the docker e2e job ran. Maybe we can make it required for changes to certain paths |
@rifelpet We don't really care about the Docker part, but the containerd version bundled for ARM64. The default Docker version doesn't change. Not sure when k8s will support the new 20.10.x branch. |
The idea about running some jobs when the container runtime changes is good though. I think we had it before containerd. I will make a PR for this soon. |
It seems a little late in the release cycle to be making these sorts of changes to 1.21. I'm particularly concerned about the change in the fallback version for ARM. |
@johngmyers This is a bugfix release, not something new. |
I am also skeptical about doing anything that isn't absolutely critical at this time. |
So this is not critical? |
A CVE could justify a late backport. |
IMHO, the risk for this is pretty small if the periodic ARM64 tests pass. This just aligns the AMD and ARM versions. |
ARM64 conformance tests passed: |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Cherry pick of #11674 on release-1.21.
#11674: Add support for Docker v20.10.7
For details on the cherry pick process, see the cherry pick requests page.