Allow overriding the ServiceAccountIssuer for IRSA #11853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/provider/aws
|
/cc @olemarkus @rifelpet |
k8s-ci-robot
added
the
needs-rebase
johngmyers
force-pushed
the
override-issuer
branch
from
4026269
to
24d1706
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/test pull-kops-e2e-aws-irsa |
|
/retest |
|
@olemarkus the pull-kops-e2e-aws-irsa job appears to be busted. See #11895. |
|
/test pull-kops-e2e-aws-irsa |
olemarkus
approved these changes
Jul 1, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows admins to override
Cluster.Spec.KubeAPIServer.ServiceAccountIssuer, allowing them to use IRSA with an external process for publishing the discovery documents.This increases the risk of a nil dereference if someone turns on IRSA or other service account issuer features on an old version of Kubernetes where they haven't enabled the feature gate. This fixes one such bug in bootstrapchannelbuilder and adjusts the test to specify a k8s version that does support the feature under test.