Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons/metrics-server] Bump minor version #12198

Merged

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Aug 24, 2021

Updating image and manifest to latest stable version.

Signed-off-by: dntosas ntosas@gmail.com

Updating image and manifest to latest stable version.

Signed-off-by: dntosas <ntosas@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2021
@johngmyers
Copy link
Member

/ok-to-test

Changing the port is concerning.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2021
@olemarkus
Copy link
Member

Changing the port of the backend service will make the service blip until the new Pods are ready to serve. I am a bit ambivalent between just following upstream and if this change is really necessary. Upstream doesn't give a particularly good reason for using 443 other than that they couldn't do so before due to missing caps.

Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While running watch kubectl top nodes during the upgrade, I could not see a single disruption. There was also not a single complaint from the apiserver about not being able to reach metrics-server. So I think we are good.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit bf559f0 into kubernetes:master Aug 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 28, 2021
k8s-ci-robot added a commit that referenced this pull request Aug 28, 2021
…198-origin-release-1.22

Automated cherry pick of #12198: Bump minor version
@johngmyers johngmyers modified the milestones: v1.22, v1.23 Aug 28, 2021
@dntosas dntosas deleted the metrics-server-bump-minor-version branch August 29, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants