-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addons/metrics-server] Bump minor version #12198
[addons/metrics-server] Bump minor version #12198
Conversation
Updating image and manifest to latest stable version. Signed-off-by: dntosas <ntosas@gmail.com>
Hi @dntosas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Changing the port is concerning. |
Changing the port of the backend service will make the service blip until the new Pods are ready to serve. I am a bit ambivalent between just following upstream and if this change is really necessary. Upstream doesn't give a particularly good reason for using 443 other than that they couldn't do so before due to missing caps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While running watch kubectl top nodes
during the upgrade, I could not see a single disruption. There was also not a single complaint from the apiserver about not being able to reach metrics-server. So I think we are good.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…198-origin-release-1.22 Automated cherry pick of #12198: Bump minor version
Updating image and manifest to latest stable version.
Signed-off-by: dntosas ntosas@gmail.com