Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AWS LBC to attach certificates #12309

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

olemarkus
Copy link
Member

Fixes #11446

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2021
@olemarkus
Copy link
Member Author

/retest

@olemarkus olemarkus added this to the v1.23 milestone Oct 20, 2021
@johngmyers
Copy link
Member

The only question would be whether there would be a resource with the elbv2.k8s.aws/cluster tag but not the KubernetesCluster tag.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit af85e5e into kubernetes:master Oct 23, 2021
k8s-ci-robot added a commit that referenced this pull request Oct 24, 2021
…309-origin-release-1.22

Automated cherry pick of #12309: Allow AWS LBC to attach certificates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support AWS Load Balancer Controller addon
3 participants