Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate aws-sdk-go/aws to aws-sdk-go-v2/aws #16444

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Migrate aws-sdk-go/aws to aws-sdk-go-v2/aws #16444

merged 2 commits into from
Apr 1, 2024

Conversation

rifelpet
Copy link
Member

Ref: #16424

In an effort to reduce the diffs when migrating the last few largest services, this migrates most of the usage of aws pointer conversion methods to use the v2 SDK.

I left files that still use v1's aws.Config

@k8s-ci-robot k8s-ci-robot added area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/aws Issues or PRs related to aws provider size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/rolling-update and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 31, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 31, 2024
@rifelpet
Copy link
Member Author

/cc @hakman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@hakman
Copy link
Member

hakman commented Apr 1, 2024

Nice approach. Thanks!

@k8s-ci-robot k8s-ci-robot merged commit f3b2159 into kubernetes:master Apr 1, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Apr 1, 2024
@BrewTestBot BrewTestBot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup area/provider/aws Issues or PRs related to aws provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@rifelpet @k8s-ci-robot @hakman