Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raising logging levels and removing dead code #3051

Merged
merged 1 commit into from
Jul 28, 2017
Merged

raising logging levels and removing dead code #3051

merged 1 commit into from
Jul 28, 2017

Conversation

chrislovecnm
Copy link
Contributor

Fixes: #3049

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2017
@chrislovecnm
Copy link
Contributor Author

/assign @sethpollack @andrewsykim

@justinsb
Copy link
Member

LGTM, but 1.7.1

@justinsb justinsb added this to the 1.7.1 milestone Jul 26, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2017
@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, justinsb

Associated issue: 3049

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [chrislovecnm,justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e6c785a into kubernetes:master Jul 28, 2017
@chrislovecnm chrislovecnm deleted the logging-cleanup branch December 30, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@sethpollack sethpollack

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
6 participants
@chrislovecnm @justinsb @k8s-github-robot @sethpollack @andrewsykim @k8s-ci-robot