Kops Replace Command - create unprovisioned #3089

gambol99 · 2017-07-29T11:51:25Z

The current 'kops replace' fails if the resource does not exist, which is annoying if you want to use the feature to drive your CI. This PR adds a --create option to create any resource which does not exist. At the moment we limit this to instanceGroups only. I'd also like to see this command perhaps be renamed to kops apply?

added a --create command line option to the replace command to create unprovisioned resources

k8s-ci-robot · 2017-07-29T11:51:32Z

Hi @gambol99. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gambol99 · 2017-07-31T10:22:03Z

/assign @justinsb

justinsb · 2017-08-04T04:34:11Z

So this LGTM. But ... naming debate :-)

kubectl replace has --force, which does a similar thing:

> kubectl create configmap a --dry-run -oyaml | kubectl replace -f -
Error from server (NotFound): error when replacing "STDIN": configmaps "a" not found
> kubectl create configmap a --dry-run -oyaml | kubectl replace --force -f -
configmap "a" replaced

Technically though --force will also delete the item and recreate it, which is useful e.g. if you have a service with a ClusterIP I guess. So that is a little different.

I'm happy to go with --create, but if you actually would prefer semantics like --force, let's use --force... WDYT?

(The backstory here is that as we bring kops server up, any kops vs kubectl CLI tooling differences will be very confusing.)

apply for kubectl is much more complex logic than replace (take a peek at kubernetes/kubernetes#1702 ). Annoyingly it is all done client-side in kubectl so it isn't something we can just drop in yet. But that's why I'm wary of kops apply :-)

justinsb · 2017-08-04T04:26:04Z

cmd/kops/replace.go

@@ -123,16 +132,32 @@ func RunReplace(f *util.Factory, cmd *cobra.Command, out io.Writer, c *ReplaceOp
 				if cluster == nil {
 					return fmt.Errorf("cluster %q not found", clusterName)
 				}
-				_, err = clientset.InstanceGroupsFor(cluster).Update(v)
+				// @check if the instancegroup exists already


Out of interest, why the @check and not just check?

Just a annoying little personal quirk of mine .. I'm sure i've used it in other PRs here, i'll update and change them :-)

justinsb · 2017-08-04T04:27:00Z

cmd/kops/replace.go

 				if err != nil {
-					return fmt.Errorf("error replacing instanceGroup: %v", err)
+					return fmt.Errorf("unable to check for instanceGroup: %v", err)


Interesting... I'm surprised this doesn't return an error where errors.IsNotFound(err) == true.

Indeed ... I did look to see if an error was return, as I figured there would be a ResourceNotFound or alike; but resources which are not there simply returned a nil and no error.

gambol99 · 2017-08-04T10:11:19Z

Technically though --force will also delete the item and recreate it, which is useful e.g. if you have a service with a ClusterIP I guess. So that is a little different.

I'm happy to go with --create, but if you actually would prefer semantics like --force, let's use --force... WDYT?

hi @justinsb .. I think your right and using --force makes more sense. Keeping the command line as similar to kubectl helps everyone.

gambol99 · 2017-08-04T10:26:49Z

@justinsb ... changes made

The current 'kops replace' fails if the resource does not exist, which is annoying if you want to use the feature to drive your CI. This PR adds a --create option to create any resource which does not exist. At the moment we limit this to instanceGroups only. I'd also like to see this command perhaps be renamed to kops apply?

…o the kubectl syntax

justinsb · 2017-08-06T20:31:58Z

/ok-to-test

/lgtm

k8s-github-robot · 2017-08-06T20:32:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-06T21:05:08Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-06T21:37:11Z

Automatic merge from submit-queue

sellers · 2017-11-02T14:48:27Z

This made it into kops 1.7.1-beta.2 (git-26ca294) but it did not make it into 1.7.1 release?

This PR fixes the `kops replace --force` flag which was introduce in [#PR3099](kubernetes#3089). The `--force` stopped working when 65aea59 was merged and the api started returning an actual error for NotFound

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2017

k8s-ci-robot assigned justinsb Jul 31, 2017

gambol99 mentioned this pull request Jul 31, 2017

kops replace should behave like kubectl apply? #2941

Closed

gambol99 force-pushed the replace_cmd branch 2 times, most recently from 95dc712 to fc2bd6f Compare August 3, 2017 19:32

justinsb reviewed Aug 4, 2017

View reviewed changes

gambol99 added 3 commits August 4, 2017 20:44

- updated the generated documentation with the new cli option

70144d1

- fixing up the flag name from --create to --force to make it align t…

3599e64

…o the kubectl syntax

gambol99 force-pushed the replace_cmd branch from f6f28a9 to 3599e64 Compare August 4, 2017 19:44

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2017

k8s-github-robot merged commit ca1ebbf into kubernetes:master Aug 6, 2017

gambol99 mentioned this pull request Dec 5, 2017

kops replace --create not working #4012

Closed

gambol99 mentioned this pull request Jan 15, 2018

Kops Replace Force #4275

Merged

gambol99 deleted the replace_cmd branch February 22, 2019 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kops Replace Command - create unprovisioned #3089

Kops Replace Command - create unprovisioned #3089

gambol99 commented Jul 29, 2017

k8s-ci-robot commented Jul 29, 2017

gambol99 commented Jul 31, 2017

justinsb commented Aug 4, 2017

justinsb Aug 4, 2017

gambol99 Aug 4, 2017

justinsb Aug 4, 2017

gambol99 Aug 4, 2017

gambol99 commented Aug 4, 2017

gambol99 commented Aug 4, 2017

justinsb commented Aug 6, 2017

k8s-github-robot commented Aug 6, 2017

k8s-github-robot commented Aug 6, 2017

k8s-github-robot commented Aug 6, 2017

sellers commented Nov 2, 2017

Kops Replace Command - create unprovisioned #3089

Kops Replace Command - create unprovisioned #3089

Conversation

gambol99 commented Jul 29, 2017

k8s-ci-robot commented Jul 29, 2017

gambol99 commented Jul 31, 2017

justinsb commented Aug 4, 2017

justinsb Aug 4, 2017

Choose a reason for hiding this comment

gambol99 Aug 4, 2017

Choose a reason for hiding this comment

justinsb Aug 4, 2017

Choose a reason for hiding this comment

gambol99 Aug 4, 2017

Choose a reason for hiding this comment

gambol99 commented Aug 4, 2017

gambol99 commented Aug 4, 2017

justinsb commented Aug 6, 2017

k8s-github-robot commented Aug 6, 2017

k8s-github-robot commented Aug 6, 2017

k8s-github-robot commented Aug 6, 2017

sellers commented Nov 2, 2017