Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade kubernetes-dashboard image version #3104

Closed
wants to merge 1 commit into from

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Aug 1, 2017

upgrade kubernetes-dashboard image version from 1.6.1 to 1.6.3

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @zouyee. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zouyee
We suggest the following additional approver: justinsb

Assign the PR to them by writing /assign @justinsb in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@zouyee
Copy link
Member Author

zouyee commented Aug 1, 2017

/assign @justinsb

@justinsb
Copy link
Member

justinsb commented Aug 1, 2017

Thanks @zouyee - I may be missing something, but the manifest also has to be created - see #3075 as an example. That PR is only bumping to 1.6.2 though.

@justinsb
Copy link
Member

justinsb commented Aug 4, 2017

It looks like #3075 is also going to bump to 1.6.3 now...

@justinsb
Copy link
Member

justinsb commented Aug 4, 2017

(Thank you though for the contribution, and for highlighting the 1.6.3 availability!)

@justinsb
Copy link
Member

justinsb commented Aug 6, 2017

#3075 has now merged, so I think this PR is moot? Closing, but if I've missed something please let me know / reopen.

@justinsb justinsb closed this Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-changes needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants