Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-autoscaler should use dnsPolicy Default #3395

Merged
merged 1 commit into from
Sep 19, 2017
Merged

cluster-autoscaler should use dnsPolicy Default #3395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/cluster-autoscaler/v1.4.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ spec:
- name: ssl-certs
hostPath:
path: {{SSL_CERT_PATH}}
dnsPolicy: "Default"
nodeSelector:
node-role.kubernetes.io/master: ""
tolerations:
Expand Down
1 change: 1 addition & 0 deletions addons/cluster-autoscaler/v1.6.0.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ spec:
- name: ssl-certs
hostPath:
path: {{SSL_CERT_PATH}}
dnsPolicy: "Default"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to make this host only, and ignore kube dns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kubernetes docs are a bit lacking here, from my understanding, dnsPolicy: Default is exacty that, setting the dns lookup to be host only. The default value for dnsPolicy is surprisingly not Default, it's ClusterFirst which is kube dns only 😛

nodeSelector:
node-role.kubernetes.io/master: ""
tolerations:
Expand Down