Adding three new funcs for cloud providers, for refactoring delete and get #3442
Conversation
k8s-ci-robot
added
size/L
chrislovecnm
force-pushed
the
new-cloud-interface-methods
branch
from
b557c24
to
e1813b2
Compare
|
Marking this a WIP, I want to get in a PR first with the aws code first, and get that tested. |
chrislovecnm
force-pushed
the
new-cloud-interface-methods
branch
from
e1813b2
to
46b9590
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
pkg/resources/digitalocean/cloud.go
Outdated
| @@ -76,6 +79,18 @@ func NewCloud(region string) (*Cloud, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func (c *Cloud) GetCloudGroups(cluster *kops.Cluster, instancegroups []*kops.InstanceGroup, warnUnmatched bool, nodeMap map[string]*v1.Node) (map[string]*fi.CloudGroup, error) { | |||
| return nil, fmt.Errorf("not implemented yet") | |||
There was a problem hiding this comment.
From someone that has been bitten by this many times: it is nice to print fmt.Errorf("Cloud::GetCloudGroups not implemented yet") because otherwise you just see "not implemented yet" and you don't know which method it is!
Or you can panic() or glog.Fatalf, both of which give a stack trace
|
Moving out of WIP, will update the err messages. Testing is looking great. |
chrislovecnm
force-pushed
the
new-cloud-interface-methods
branch
from
46b9590
to
a96bfec
Compare
|
@justinsb PTLA - added debug logging and better error messages |
|
We have #3446 ... need to close |
k8s-github-robot
added
the
needs-rebase
|
@chrislovecnm PR needs rebase |
|
Closing |
Adding three new methods for cloud providers
These three methods will allow the refactoring of funcs in instancegroups.go https://github.com/kubernetes/kops/blob/master/pkg/instancegroups/instancegroups.go#L437
This refactoring will allow for rolling-updates across multiple cloud providers.
This code is not wired in.
The actual code that is included in this PR is copied from resources and will be refactored out later.