Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Initial support for nvme #3914

Closed
wants to merge 1 commit into from
Closed

WIP: Initial support for nvme #3914

wants to merge 1 commit into from

Conversation

justinsb
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: andrewsykim

Assign the PR to them by writing /assign @andrewsykim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

This was referenced Nov 23, 2017
Closed
Closed
@justinsb justinsb force-pushed the nvme_support branch 3 times, most recently from 58c876d to 142436c Compare November 23, 2017 08:24
@chrislovecnm
Copy link
Contributor

Does this need to go into kops 1.8?

@justinsb
Copy link
Member Author

It's required if we want to support c5 masters. cf kubernetes/kubernetes#56155

@justinsb justinsb force-pushed the nvme_support branch 3 times, most recently from be879b9 to ab832dd Compare November 24, 2017 23:14
@justinsb justinsb added this to the 1.8.0 milestone Nov 26, 2017
@justinsb
Copy link
Member Author

Tentatively putting this into the 1.8.0 milestone to keep it on the radar

@justinsb
Copy link
Member Author

justinsb commented Dec 1, 2017

We did #3969 instead

@justinsb justinsb closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @chrislovecnm