Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Weave Net to v2.4.0 #5552

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Bump Weave Net to v2.4.0 #5552

merged 1 commit into from
Aug 14, 2018

Conversation

brb
Copy link
Contributor

@brb brb commented Jul 30, 2018

  • New manifest for k8s 1.8.0 due to FileOrCreate mount type.
  • RBAC for updating NetworkUnavailable node status.
  • Dropped support for legacy NetworkPolicy (k8s pre-1.7).
$ diff upup/models/cloudup/resources/addons/networking.weave/k8s-1.{7,8}.yaml.template
240a241
>             type: FileOrCreate

Full changelog: https://github.com/weaveworks/weave/releases/tag/v2.4.0

- New manifest for k8s 1.8.0 due to FileOrCreate mount type.
- RBAC for updating NetworkUnavailable node status.
- Dropped support for legacy NetworkPolicy (k8s pre-1.7).

Full changelog: https://github.com/weaveworks/weave/releases/tag/v2.4.0
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2018
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2018
@mikesplain
Copy link
Contributor

This looks prime for 1.11 since 1.10 is imminent.

/milestone 1.11

@idyll
Copy link

idyll commented Aug 10, 2018

Weave 2.4.0 is important for AWS NLB.

Right now the client ip isn't making it through and the fix is in Weave 2.4.0

Please consider this for 1.10.

@justinsb
Copy link
Member

Given the importance...

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2018
@justinsb justinsb added cherrypick-candidate and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2018
@justinsb
Copy link
Member

/approve

Definitely a github race condition / bug here with label removal!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brb, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5f13be3 into kubernetes:master Aug 14, 2018
@idyll
Copy link

idyll commented Aug 15, 2018

Thank you!

k8s-ci-robot added a commit that referenced this pull request Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants