Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor servergroup module from gophercloud #5678

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Vendor servergroup module from gophercloud #5678

merged 1 commit into from
Aug 30, 2018

Conversation

lblackstone
Copy link
Contributor

@lblackstone lblackstone commented Aug 21, 2018 •
edited
Loading

  • Bump gophercloud sha to f29afc2
  • Add a prereq check for bazel and dep which is needed by make dep-ensure
  • Document the process to add a vendored dependency

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2018
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2018
Vendor servergroup module from gophercloud
c4e2db4 
* Bump gophercloud sha to f29afc2
* Add a prereq check for bazel and dep which is needed by `make dep-ensure`
* Document the process to add a vendored dependency
@lblackstone
Copy link
Contributor Author

@mikesplain Had to rebase changes, but RFR again. Thanks!

@mikesplain
Copy link
Contributor

Thanks @lblackstone! Approving since this is mostly affecting openstack.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lblackstone, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2018
@lblackstone
Copy link
Contributor Author

Hmm, seems that the travis CI job is not reporting back status. Going to close and reopen the PR to see if that unsticks it.

@lblackstone lblackstone reopened this Aug 30, 2018
@mikesplain
Copy link
Contributor

For future reference @lblackstone open source travis jobs can be retriggered in the UI by anyone.

kops - travis ci 2018-08-30 15-05-29

@lblackstone
Copy link
Contributor Author

lblackstone commented Aug 30, 2018 •
edited
Loading

Aha, good to know. Thanks!

Edit: Actually, it must have something to do with the permissions on my account. I don't the see restart option you mentioned, although I guess I may have been able to retrigger it with the /test command.

screen shot 2018-08-30 at 1 10 12 pm

Edit 2:
Yep, requires write permission on the repo.

@lblackstone
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e25b216 into kubernetes:master Aug 30, 2018
@lblackstone lblackstone deleted the update-vendor branch August 30, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lblackstone @mikesplain @k8s-ci-robot