Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using which, CoreOS doesn't always have it #5795

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Avoid using which, CoreOS doesn't always have it #5795

merged 2 commits into from
Sep 21, 2018

Conversation

justinsb
Copy link
Member

We just try executing curl --version instead, and fall back to wget.
We can't use wget --version because busybox wget doesn't support
--version.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2018
geojaz
geojaz approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you; and again, thanks for documenting the reasoning/logic because this stuff will get forgotten!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2018
@geojaz geojaz mentioned this pull request Sep 17, 2018
Closed
@rdrgmnzs
Copy link
Contributor

Looks like we need to update all the tests to match the nodeup template changes.

@justinsb
Avoid using which, CoreOS doesn't always have it
8a483c1 
We just try executing `curl --version` instead, and fall back to wget.
We can't use `wget --version` because busybox wget doesn't support
`--version`.
@justinsb
Update expected test output for script changes
237043d
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2018
@rdrgmnzs
Copy link
Contributor

Thanks @justinsb
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, justinsb, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c4bdda2 into kubernetes:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geojaz geojaz geojaz approved these changes

Assignees

@rdrgmnzs rdrgmnzs

@geojaz geojaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @rdrgmnzs @k8s-ci-robot @geojaz