Stop cloudformation output switching to literal quotes #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/S
yaml can't store the \r character, so we strip the \r characters in the expected output to keep the yaml output in block-quote style. Also don't Fatalf out of an error, rather Errorf so we print all problems.
justinsb
force-pushed
the
strict_cloudformation_output_checking
branch
from
88182eb
to
1ad7a84
Compare
justinsb
changed the title
|
PR updated to reflect what was actually going wrong. |
|
/test pull-kops-e2e-kubernetes-aws |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaml can't store the \r character, so we strip the \r characters in
the expected output to keep the yaml output in block-quote style.
Also don't Fatalf out of an error, rather Errorf so we print all
problems.