-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Calico upgrade job to use the correct version #6156
Fix Calico upgrade job to use the correct version #6156
Conversation
Hi @tmjd. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also bump the version here:
kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go
Lines 648 to 649 in 5b34d3d
"k8s-1.7-v3": "3.3.1-kops.2", | |
} |
In this case since it looks like it was already bumped, just change it from 3.3.1-kops.2
to 3.3.1-kops.3
to have kops pick it up as a change
@@ -578,7 +578,7 @@ subjects: | |||
apiVersion: batch/v1 | |||
kind: Job | |||
metadata: | |||
name: calico-complete-upgrade | |||
name: calico-complete-upgrade-v331 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes, since jobs can't be updated as themselves 👍
/ok-to-test |
@tmjd seems like we should likely cherry-pick this into 1.11 as well, thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmjd thanks for cleaning up my mess. this LGTM!
@mikesplain Yes this should be cherry-picked to 1.11. |
280a073
to
d2e9fcb
Compare
Thanks @tmjd! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, tmjd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…56-origin-release-1.11 Automated cherry pick of #6156: Fix Calico upgrade job to use the correct version
No description provided.