-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing kops-4049 #6210
Fixing kops-4049 #6210
Conversation
Hi @mmerrill3. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
e631101
to
248f08b
Compare
/retest |
/assign @justinsb |
@mmerrill3 this is great thank you for adding in, and for the test addition too :) LGTM from my perspective but I'll leave for @justinsb to approve as I believe he added a comment in your previous PR around this, incase there's any outstanding discussion to be had. |
/lgtm Thanks @mmerrill3 ! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KashifSaadat, mmerrill3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixing issue #4049 for release 1.11 or later