Upgrade base image to alpine 3.8 and GO to 1.10.8

[ricardo-larosa]

Hi There,
kops 1.11 needs at least go1.10.3, I am setting go version to 1.10.8 because is the latest of the 1.10 branch. This also forces to update to alpine:3.8 (in the previous versions go 1.10 is not supported)
solves #6457

[k8s-ci-robot]

Hi @ricardo-larosa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ricardo-larosa]

/assign @mikesplain

[zetaab]

/lgtm

[ricardo-larosa]

/retest

[mikesplain]

Thanks @ricardo-larosa!

/retest
/lgtm
/approve

[justinsb]

Oh - I think the surprising thing here is that this PR is not against the master branch. I presume that is not deliberate?

[mikesplain]

Good point @justinsb! @ricardo-larosa I'm assuming you want this in master not 1.11. If it is deemed necessary for a patch release, we can cherry pick it in.

/lgtm cancel

[ricardo-larosa]

Hi, it should be in 1.11 and master, otherwise, if someone wants to target 1.11 using docker build --build-arg KOPS_GITISH=release-1.11 -t kops:1.11.0 . will fail with the error described in #6457 @mikesplain @justinsb

[justinsb]

That makes sense @ricardo-larosa - the way we achieve that is that we merge into master and then cherry-pick back to the release branches. I'll mark this PR for cherry-picking, but can you change the target branch to master please?

[k8s-ci-robot]

@ricardo-larosa: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kops-e2e-kubernetes-aws-stable2	cb3d56d	link	/test pull-kops-e2e-kubernetes-aws-stable2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, ricardo-larosa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ricardo-larosa]

Done. @justinsb

[justinsb]

(When it passes CI, I'm going to squash-and-merge, as I'm a little worried by the 26 commits that are currently showing)

[ricardo-larosa]

(When it passes CI, I'm going to squash-and-merge, as I'm a little worried by the 26 commits that are currently showing)

Yes. Next time when facing similar changes I will create the PRs from master.
I was not aware of the workflow of cherry-picking to release branches from master.