Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing Resource Request & Limits for CoreDNS #6719

Merged
merged 12 commits into from
Apr 4, 2019
Merged

Allow customizing Resource Request & Limits for CoreDNS #6719

merged 12 commits into from
Apr 4, 2019

Conversation

granular-ryanbonham
Copy link
Contributor

We have needed to adjust the default request/limits for coredns. This allows you to customize these settings as part of the cluster config.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2019
@granular-ryanbonham granular-ryanbonham changed the title Allow customizing Resource Request & Limits for CoreDNS WIP: Allow customizing Resource Request & Limits for CoreDNS Apr 2, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
@granular-ryanbonham granular-ryanbonham changed the title WIP: Allow customizing Resource Request & Limits for CoreDNS Allow customizing Resource Request & Limits for CoreDNS Apr 2, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2019
mikesplain
mikesplain suggested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good but needs a few more changes.

For this to get deployed, you'll also need to bump the version number here:

kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

Line 259 in e5a745b

version := "1.3.1-kops.2"
(just bump the kops.2 to kops.3) and similarly here:

kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

Line 279 in e5a745b

version := "1.3.0-kops.1"

upup/models/cloudup/resources/addons/coredns.addons.k8s.io/k8s-1.12.yaml.template Show resolved Hide resolved
@mikesplain
Copy link
Contributor

/assign

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2019
@mikesplain
Copy link
Contributor

This looks pretty good @granular-ryanbonham, can you bump the version mentioned here too? That'll ensure your changes get picked up #6719 (review)

mikesplain
mikesplain approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @granular-ryanbonham!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: granular-ryanbonham, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 017c5ef into kubernetes:master Apr 4, 2019
@mikesplain mikesplain mentioned this pull request Apr 4, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 5, 2019
@k8s-ci-robot
Merge pull request #6731 from mikesplain/automated-cherry-pick-of-#67…
4d6e61d 
…19-origin-release-1.12

Automated cherry pick of #6719: Add DNS Resource Settings
@granular-ryanbonham granular-ryanbonham mentioned this pull request Apr 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@mikesplain mikesplain mikesplain approved these changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@granular-ryanbonham @mikesplain @k8s-ci-robot @rifelpet