LaunchTemplate Version Name Fix ..

[gambol99]

The commit eca2b0a added the version to the name of the which created a loop on NeedUpdate, as the empty version will never be equal to the original name.

• Revert "User version number as well as name when checking LaunchTemplates

This reverts commit eca2b0a.

[gambol99]

/assign @KashifSaadat

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gambol99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gambol99]

fixes #6796

[granular-ryanbonham]

Reverting this will cause us to reintroduce #6751 where launchtemplate are not rolled correctly. I am looking over the code more to see why we are seeing different behavior.

[gambol99]

So having played about with the a terraform target things appears to be working as expected, updates to the launch_template and autoscaling_group are reflected. The main difference is the way terraform is handling the launch_template; in api target we aren't using versions, but instead follow the same pattern as launch_configurations and creating a new LG on change; terraform appears to create a new version and thanks to the ASG using latest_version the configuration is referenced .. So just to be on the same page, is the issue in #6751 purely that the nodes which need updating are not showing up in a kops update cluster? .. @granular-ryanbonham i.e. changes are reflected by terraform in the LT and ASG but when running the command the nodes which should show up as NeedUpdate do not? ...

[KashifSaadat]

Hey @granular-ryanbonham, any luck further debugging this?

[rifelpet]

/test pull-kops-verify-gomod

[rifelpet]

is this no longer needed now that #7445 is merged?

[k8s-ci-robot]

@gambol99: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kops-verify-generated	2188281	link	/test pull-kops-verify-generated
pull-kops-verify-staticcheck	2188281	link	/test pull-kops-verify-staticcheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@gambol99: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

I'm fairly certain this is no longer needed but if it is, feel free to reopen

/close

[k8s-ci-robot]

@rifelpet: Closed this PR.

In response to this:

I'm fairly certain this is no longer needed but if it is, feel free to reopen

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.