-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubernetes versions used in integration tests #8173
Update kubernetes versions used in integration tests #8173
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nice! /lgtm |
@rifelpet @johngmyers Not sure if you already tried, but would be nice to remove the default versions of Docker for obsolete Kubernetes versions and fix the tests after that. It flags quite well tests that use very old Kubernetes versions. |
My understanding is that we're waiting until deprecation notices are backported to 1.16 and 1.17 before removing code for obsolete Kubernetes versions in master. |
My idea was not to remove it yet, but to flag and change tests easier. |
I brought up the docker versions during the call on friday. Justin said theres not as much benefit to stripping it out compared to other areas of the code base that specifically handle older k8s versions, but removing the packages and/or the k8s version -> docker version logic could certainly be done. would it simplify your containerd work at all? And yes, my plan was to get the deprecation announcement backported to 1.16 and then open a PR against master that removes the bulk of the old version support. |
In my case with containerd, there's not much to gain anymore. Was just thinking that removing the defaults would make people more inclined towards upgrading. Thanks. |
In preparation for deprecating support for older Kubernetes versions, this updates our integration tests to use supported versions.
The only fields that change in the output are
kubernetesVersion
,image
, andkubelet.anonymousAuth