Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes versions used in integration tests #8173

Merged

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Dec 21, 2019

In preparation for deprecating support for older Kubernetes versions, this updates our integration tests to use supported versions.

The only fields that change in the output are kubernetesVersion, image, and kubelet.anonymousAuth

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2019
@joshbranham
Copy link
Contributor

nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6bb9175 into kubernetes:master Dec 21, 2019
@hakman
Copy link
Member

hakman commented Dec 23, 2019

@rifelpet @johngmyers Not sure if you already tried, but would be nice to remove the default versions of Docker for obsolete Kubernetes versions and fix the tests after that. It flags quite well tests that use very old Kubernetes versions.
https://github.com/kubernetes/kops/blob/1.17.0-alpha.1/pkg/model/components/docker.go#L64-L71

@johngmyers
Copy link
Member

My understanding is that we're waiting until deprecation notices are backported to 1.16 and 1.17 before removing code for obsolete Kubernetes versions in master.

@hakman
Copy link
Member

hakman commented Dec 23, 2019

My idea was not to remove it yet, but to flag and change tests easier.
Though, removing the defaults would only make people more aware. They could still use the desired version of Docker, but would have to do it manually.

@rifelpet
Copy link
Member Author

I brought up the docker versions during the call on friday. Justin said theres not as much benefit to stripping it out compared to other areas of the code base that specifically handle older k8s versions, but removing the packages and/or the k8s version -> docker version logic could certainly be done. would it simplify your containerd work at all?

And yes, my plan was to get the deprecation announcement backported to 1.16 and then open a PR against master that removes the bulk of the old version support.

@hakman
Copy link
Member

hakman commented Dec 23, 2019

In my case with containerd, there's not much to gain anymore. Was just thinking that removing the defaults would make people more inclined towards upgrading. Thanks.

@rifelpet rifelpet deleted the integration-test-version-update branch August 6, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants