Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For dev, don't preload docker images on nodes #8196

Merged
merged 3 commits into from Jan 5, 2020

Conversation

justinsb
Copy link
Member

If we're not going to use the docker images, we don't need to preload
them - saves a bit off the boot time.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 24, 2019
@hakman
Copy link
Member

hakman commented Dec 25, 2019

Nice! This saves me a PR.

In the same context, shouldn't the LoadImage task be in the ProtokubeBuilder?

if c.config.ProtokubeImage != nil {
taskMap["LoadImage.protokube"] = &nodetasks.LoadImageTask{
Sources: c.config.ProtokubeImage.Sources,
Hash: c.config.ProtokubeImage.Hash,
Runtime: c.cluster.Spec.ContainerRuntime,
}
}

@rifelpet
Copy link
Member

rifelpet commented Jan 3, 2020

shoot, should have merged this before #8258

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 3, 2020
@rifelpet
Copy link
Member

rifelpet commented Jan 3, 2020

/test pull-kops-e2e-kubernetes-aws

If we're not going to use the docker images, we don't need to preload
them - saves a bit off the boot time.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2020
@justinsb
Copy link
Member Author

justinsb commented Jan 4, 2020

Also moved the protokube image loading into ProtokubeBuilder - thanks for the suggestion @hakman!

More logically consistent, and allows us to be lazier about loading
it when not needed.
@rifelpet
Copy link
Member

rifelpet commented Jan 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit e4da659 into kubernetes:master Jan 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants