-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For dev, don't preload docker images on nodes #8196
For dev, don't preload docker images on nodes #8196
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice! This saves me a PR. In the same context, shouldn't the LoadImage task be in the ProtokubeBuilder? kops/upup/pkg/fi/nodeup/command.go Lines 304 to 310 in 0b52b99
|
shoot, should have merged this before #8258 |
/test pull-kops-e2e-kubernetes-aws |
If we're not going to use the docker images, we don't need to preload them - saves a bit off the boot time.
b87e021
to
976724d
Compare
Also moved the protokube image loading into ProtokubeBuilder - thanks for the suggestion @hakman! |
More logically consistent, and allows us to be lazier about loading it when not needed.
e190aa3
to
e4ed13e
Compare
/lgtm |
If we're not going to use the docker images, we don't need to preload
them - saves a bit off the boot time.