Avoid a race between etcd start and volume mount #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the instance restarted but lost the volume mount, there might be a short or indefinite delay before protokube can mount the volume again. But the etcd manifest would probably still be in /etc/kubernetes/manifests from the previous run. To ensure that kubelet doesn't run etcd until the volume is actually mounted, we use a symlink to a directory on the volume itself. Thus kubelet can't start etcd until we put the volume there. We can also delete the symlink before mounting, so we have full control. Issue kubernetes#73
rifelpet
pushed a commit
to rifelpet/kops
that referenced
this pull request
Mar 23, 2018
Merging uptime integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the instance restarted but lost the volume mount, there might be a
short or indefinite delay before protokube can mount the volume again.
But the etcd manifest would probably still be in
/etc/kubernetes/manifests from the previous run.
To ensure that kubelet doesn't run etcd until the volume is actually
mounted, we use a symlink to a directory on the volume itself. Thus
kubelet can't start etcd until we put the volume there. We can also
delete the symlink before mounting, so we have full control.
Issue #73