Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coredns to 1.6.7 #8452

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

maruina
Copy link
Contributor

@maruina maruina commented Jan 31, 2020

This PR updates CoreDNS to 1.6.7 where they restore metrics on cache miss for the cache pluging as per coredns/coredns#3578

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maruina. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 31, 2020
@gjtempleton
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2020
@maruina
Copy link
Contributor Author

maruina commented Jan 31, 2020

/retest

@maruina
Copy link
Contributor Author

maruina commented Jan 31, 2020

/assign @joshbranham

@gjtempleton
Copy link
Member

gjtempleton commented Jan 31, 2020

/lgtm

Chased down the one note in the release notes which worried me:

coredns/coredns#3554

The relevant DNS fields have been marked deprecated since Dec 2016: kubernetes/dns#335 (comment)

I've also raised this regression on the existing PR upstream in k/k to update to 1.6.6 as a heads up.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
@rifelpet
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maruina, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@hakman
Copy link
Member

hakman commented Jan 31, 2020

/retest

k8s-ci-robot added a commit that referenced this pull request Feb 1, 2020
…452-upstream-release-1.16

Automated cherry pick of #8452: Update coredns to 1.6.7
k8s-ci-robot added a commit that referenced this pull request Feb 1, 2020
…452-upstream-release-1.17

Automated cherry pick of #8452: Update coredns to 1.6.7
@rajansandeep
Copy link
Contributor

This should not have been merged, as the image for 1.6.7 isn't available on gcr.io repo.

gjtempleton added a commit to gjtempleton/kops that referenced this pull request Feb 6, 2020
k8s-ci-robot added a commit that referenced this pull request Feb 7, 2020
Revert "Merge pull request #8452 from maruina/coredns-1.6.7"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants