Automated cherry pick of #8452: Update coredns to 1.6.7 #8457
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gjtempleton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| @@ -167,7 +167,7 @@ spec: | |||
| beta.kubernetes.io/os: linux | |||
| containers: | |||
| - name: coredns | |||
| image: k8s.gcr.io/coredns:1.6.6 | |||
| image: k8s.gcr.io/coredns:1.6.7 | |||
There was a problem hiding this comment.
The image for 1.6.7 isn't available in k8s.gcr.io...
It makes me wonder how #8452 and other cherry-pick PRs have passed tests.
There was a problem hiding this comment.
the presubmit e2e tests still use kubedns since it is the kops default. Maybe this is a good time to bring attention to your #7919 :)
There was a problem hiding this comment.
Aah! that makes sense.
There was a problem hiding this comment.
What's the problem here to use coredns/coredns:1.6.7 instead?
There was a problem hiding this comment.
I believe the kubernetes project moved from coredns/coredns to k8s.gcr.io/coredns so as to try to make sure that critical dependencies have a coherent "supply chain" - in particular the work going on in wg-k8s-infra. It's very much a work-in-progress though.
The good news: k8s.gcr.io/coredns:1.6.7 is now available :-)
There was a problem hiding this comment.
@justinsb I think the CoreDNS 1.6.7 version was added under #8602.
I don't see it cherry-picked to 1.15 yet or any release note for it.
@gjtempleton shouldn't this be closed?
|
/hold given the image isn't available |
k8s-ci-robot
added
the
do-not-merge/hold
|
now that kops 1.16.0 is released as stable, we probably wont be doing another 1.15 release. Do we think this is safe to close out? |
|
Yeah, probably safe to close, I think it can be covered by a note in the changelog as a known issue at most. |
gjtempleton
deleted the
automated-cherry-pick-of-#8452-upstream-release-1.15
branch
Only worry about cherry-picking back this far is the lack of cherry-picking #7794 back this far which means we can't advise anyone potentially affected by the removal of the long deprecated DNS support (coredns/coredns#3554) to override the image as discussed at office hours today.
Cherry pick of #8452 on release-1.15.
#8452: Update coredns to 1.6.7
For details on the cherry pick process, see the cherry pick requests page.