Automated cherry pick of #8467: Stop logging to /var/log/kops-controller.log #8494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing to a hostPath from a non-root container requires file ownership changes, which is difficult to roll out today. See discussion in kubernetes#8454 We were primarily using the logfile for e2e diagnostics, so we're going to look into collecting the information via other means instead. We also haven't yet shipped this logfile in a released version (though we have shipped it in beta releases)
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
johngmyers
deleted the
automated-cherry-pick-of-#8467-upstream-release-1.17
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #8467 on release-1.17.
#8467: Stop logging to /var/log/kops-controller.log
For details on the cherry pick process, see the cherry pick requests page.