Refactor cert issuance code #9130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
johngmyers
force-pushed
the
pki-refactor
branch
3 times, most recently
from
0034bbb
to
e59983c
Compare
k8s-ci-robot
added
size/XL
johngmyers
force-pushed
the
pki-refactor
branch
2 times, most recently
from
2f1562c
to
e2e4fcb
Compare
k8s-ci-robot
added
size/XXL
johngmyers
force-pushed
the
pki-refactor
branch
4 times, most recently
from
9c048df
to
e4f0b9b
Compare
johngmyers
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This looks pretty good to me. |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
johngmyers
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
johngmyers
force-pushed
the
pki-refactor
branch
2 times, most recently
from
fbc26b7
to
7038b43
Compare
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
rifelpet
reviewed
May 23, 2020
|
Thanks @johngmyers ! /lgtm |
k8s-ci-robot
added
lgtm
justinsb
reviewed
Jun 4, 2020
|
Drive-by nit, but this is a big simplification of the code - thank you @johngmyers /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9110
Pull cert issuance code up into
Keypairthen push it down intopkiwhere it can be shared by nodeup tasks.Add up to 30 days skew to the lifetimes of nodeup-generated certs, to try to cause nodes generated around the same time to expire on different days.
Decrease the lifetime of the kube-apiserver-healthcheck and master kubelet certificates from 10 years to 455 days plus skew. Increases the lifetime of the etcd-clients-ca-cilium and apiserver-to-etcd client certs from 1 year to 455 days plus skew.
Make
pki.SignNewCertificate()private.