Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #9647: Calico: upgrade "k8s-ec2-srcdst" to version v0.3.0 #9648

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Automated cherry pick of #9647: Calico: upgrade "k8s-ec2-srcdst" to version v0.3.0 #9648

merged 2 commits into from
Jul 29, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 29, 2020

Cherry pick of #9647 on release-1.18.

#9647: Calico: upgrade "k8s-ec2-srcdst" to version v0.3.0

For details on the cherry pick process, see the cherry pick requests page.

@seh
Calico: upgrade "k8s-ec2-srcdst" to version v0.3.0
9a040c3 
Upgrading the "k8s-ec2-srcdst" controller to this latest version
allows it to work correctly with the objects containing the new
"metadata.managedFields" field introduced in Kubernetes version
1.18.0.

The previous container image versions used a version of the
"client-go" library that was too old to consume these fields
correctly, causing the controller to fail repeatedly when trying to
read Node objects retrieved from the Kubernetes API server.
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jul 29, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2020
@k8s-ci-robot k8s-ci-robot added area/addons approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2020
@hakman
Copy link
Member Author

hakman commented Jul 29, 2020

/retest

@mikesplain
Copy link
Contributor

/lgtm
/approve

Though I expect you may need a couple changes to fix the jobs above.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member Author

hakman commented Jul 29, 2020

@mikesplain Kubekins images changed to Golang 1.15, but Kops 1.18 requires Golang 1.13, which is a bit of a problem.

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/rolling-update and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 29, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2020 •
edited
Loading

@hakman: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-verify-bazel 223131c link /test pull-kops-verify-bazel
pull-kops-verify-gomod 223131c link /test pull-kops-verify-gomod

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman hakman mentioned this pull request Jul 29, 2020
Merged
@mikesplain
Copy link
Contributor

Assuming tests will pass after ^
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020
@hakman
Copy link
Member Author

hakman commented Jul 29, 2020

Thanks @mikesplain .

@mikesplain
Copy link
Contributor

Thank YOU!

@hakman hakman closed this Jul 29, 2020
@hakman hakman reopened this Jul 29, 2020
@hakman hakman closed this Jul 29, 2020
@hakman hakman reopened this Jul 29, 2020
Fix int to string conversions
9abfcb8 
(cherry picked from commit 5a9cc3d)
@hakman hakman force-pushed the automated-cherry-pick-of-#9647-upstream-release-1.18 branch from 223131c to 9abfcb8 Compare July 29, 2020 15:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020
@mikesplain
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 116d255 into kubernetes:release-1.18 Jul 29, 2020
@hakman hakman deleted the automated-cherry-pick-of-#9647-upstream-release-1.18 branch July 29, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/provider/aws Issues or PRs related to aws provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @mikesplain @k8s-ci-robot @seh