Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DynamicKubeletConfigare by default in v1.12 #957

Closed
stewart-yu opened this issue Jun 29, 2018 · 2 comments
Closed

Enable DynamicKubeletConfigare by default in v1.12 #957

stewart-yu opened this issue Jun 29, 2018 · 2 comments
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@stewart-yu
Copy link
Contributor

stewart-yu commented Jun 29, 2018 •
edited
Loading

DynamicKubeletConfigare being moved to beta and we should determine if we are ready to enable and default it in kubeadm.
xref PRs：

  1. graduate DynamicKubeletConfig feature to beta kubernetes#64275 in kubelet 's DynamicKubeletConfigare;
  2. Issue about DynamicKubeletConfigare is Dynamic Kubelet Configuration enhancements#281
  3. The PR we add DynamicKubeletConfigare feature-gate in kubeadm is Add kubeadm support for Kubelet Dynamic Configuration kubernetes#55803

I'd be in favor of enabling DynamicKubeletConfigareas a default, syncing with kubelet.
/cc @kubernetes/sig-cluster-lifecycle-misc @kubernetes/sig-network-misc
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jun 29, 2018
@stewart-yu stewart-yu mentioned this issue Jun 29, 2018
Merged
@stewart-yu
Copy link
Contributor Author

/cc @luxas @timothysc @fabriziopandini

@timothysc
Copy link
Member

Per sig discussion we do not want to enable it by default but keep it as an opt-in behavior.

We are currently leveraging the config file mechanism and will continue todo so.

k8s-github-robot referenced this issue in kubernetes/kubernetes Jul 14, 2018
Merge pull request #65576 from stewart-yu/stewart-kubelet-read#02
49454a2 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[kubeadm]fix DynamicKubeletConfig feature to beta

**What this PR does / why we need it**:
As [PR](#64275) get merged,  DynamicKubeletConfig feature convert to  `beta` in v1.11, and set to `true` in default.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #[https://github.com/kubernetes/kubeadm/issues/957](https://github.com/kubernetes/kubeadm/issues/957)

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timothysc @k8s-ci-robot @stewart-yu