Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the performance of schedulinggates #117780

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sourcelliu
Copy link
Contributor

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

I wrote a benchmak in my local env, like this:

func BenchmarkPreEnqueue(b *testing.B) {
	b.ResetTimer()
	p, _ := New(nil, nil, feature.Features{EnablePodSchedulingReadiness: true})
	pod := st.MakePod().Name("p").SchedulingGates([]string{"foo", "bar", "a", "b", "c"}).Obj()
	for i := 0; i < b.N; i++ {
		p.(framework.PreEnqueuePlugin).PreEnqueue(context.Background(), pod)
	}
}
  • original:
goos: darwin
goarch: amd64
pkg: k8s.io/kubernetes/pkg/scheduler/framework/plugins/schedulinggates
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkPreEnqueue-16    	 1220508	       993.1 ns/op	     472 B/op	      13 allocs/op
BenchmarkPreEnqueue-16    	 1000000	      1028 ns/op	     472 B/op	      13 allocs/op
BenchmarkPreEnqueue-16    	 1000000	      1029 ns/op	     472 B/op	      13 allocs/op
BenchmarkPreEnqueue-16    	 1000000	      1020 ns/op	     472 B/op	      13 allocs/op
  • PR:
goos: darwin
goarch: amd64
pkg: k8s.io/kubernetes/pkg/scheduler/framework/plugins/schedulinggates
cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
BenchmarkPreEnqueue-16    	 1437207	       796.2 ns/op	     312 B/op	      10 allocs/op
BenchmarkPreEnqueue-16    	 1521619	       795.2 ns/op	     312 B/op	      10 allocs/op
BenchmarkPreEnqueue-16    	 1519863	       784.1 ns/op	     312 B/op	      10 allocs/op
BenchmarkPreEnqueue-16    	 1523612	       799.1 ns/op	     312 B/op	      10 allocs/op

The execution time of the PR version is reduced by 20% compared to the master version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 4, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sourcelliu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 4, 2023
@dims
Copy link
Member

dims commented Oct 24, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2023
@chendave
Copy link
Member

/assign

Copy link
Member

@chendave chendave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

double checked.

@kubernetes/sig-scheduling-approvers someone from the list pls help to approve.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92a473f90efb941977782435522bbcd9e94cbae9

Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, sanposhiho, sourcelliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 53e9194 into kubernetes:master Oct 26, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants