Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict addition of new e2e test images with a verify script #122748

Closed
BenTheElder opened this issue Jan 12, 2024 · 6 comments · Fixed by #122751
Closed

Restrict addition of new e2e test images with a verify script #122748

BenTheElder opened this issue Jan 12, 2024 · 6 comments · Fixed by #122751
Assignees
Labels
area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@BenTheElder
Copy link
Member

We should check the images configured in test/e2e to ensure we're not adding new images:

func initImageConfigs(list RegistryList) (map[ImageID]Config, map[ImageID]Config) {

In almost all cases, test/images/agnhost should be extended to support any missing functionality and used as the sole image for new tests. This has been the policy in SIG Testing for at least a few years now.

To prevent regressing on this, we should check the list of images and permit tag updates but NOT adding any more names to the list.

We can do this with an allowlist against e2e.test --list-images

/sig testing
/kind test

Others are welcome to work on this, but I'll submit something soon if nobody beats me to it.
/assign

Follow up to #122747, we should aim to ship something this release (1.30).

@BenTheElder BenTheElder added this to the v1.30 milestone Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

We should check the images configured in test/e2e to ensure we're not adding new images:

func initImageConfigs(list RegistryList) (map[ImageID]Config, map[ImageID]Config) {

In almost all cases, test/images/agnhost should be extended to support any missing functionality and used as the sole image for new tests. This has been the policy in SIG Testing for at least a few years now.

To prevent regressing on this, we should check the list of images and permit tag updates but NOT adding any more names to the list.

We can do this with an allowlist against e2e.test --list-images

/sig testing
/kind test

Others are welcome to work on this, but I'll submit something soon if nobody beats me to it.
/assign

Follow up to #122747, we should aim to ship something this release (1.30).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 12, 2024
@BenTheElder BenTheElder added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 12, 2024
@BenTheElder BenTheElder added area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 12, 2024
@MaryamTavakkoli
Copy link

Hello!
Release Signal shadow here.
This issue has not been updated for a long time, so I'd like to check what's the status. The code freeze is starting 02:00 UTC Wednesday 6th March 2024 / 18:00 PDT Tuesday 5th March 2024 (less than a month from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time.

As this issue is tagged for 1.30, is it still planned for this release?

@BenTheElder
Copy link
Member Author

We still intend to do this and it's a test-only change so we're aiming for test freeze.

@MaryamTavakkoli
Copy link

Hello!
Release Signal shadow here.
I'd like to check what's the status. The code freeze is starting 02:00 UTC Wednesday 6th March 2024 / 18:00 PDT Tuesday 5th March 2024 in a week, and we want to ensure that each PR has a chance to be merged on time.

Is it still planned for this release?

@pacoxu
Copy link
Member

pacoxu commented Mar 25, 2024

As #122751 has no update recently,
/milestone clear
we may make it in v1.31.

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 25, 2024
@BenTheElder
Copy link
Member Author

Yeah I think we have to revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants