-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict addition of new e2e test images with a verify script #122748
Comments
@BenTheElder: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello! As this issue is tagged for 1.30, is it still planned for this release? |
We still intend to do this and it's a test-only change so we're aiming for test freeze. |
Hello! Is it still planned for this release? |
As #122751 has no update recently, |
Yeah I think we have to revisit this later. |
We should check the images configured in test/e2e to ensure we're not adding new images:
kubernetes/test/utils/image/manifest.go
Line 229 in 83e6636
In almost all cases, test/images/agnhost should be extended to support any missing functionality and used as the sole image for new tests. This has been the policy in SIG Testing for at least a few years now.
To prevent regressing on this, we should check the list of images and permit tag updates but NOT adding any more names to the list.
We can do this with an allowlist against
e2e.test --list-images
/sig testing
/kind test
Others are welcome to work on this, but I'll submit something soon if nobody beats me to it.
/assign
Follow up to #122747, we should aim to ship something this release (1.30).
The text was updated successfully, but these errors were encountered: