Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThirdParty E2E framework tests should be [Flaky] in kube 1.4 #32296

Closed
derekwaynecarr opened this issue Sep 8, 2016 · 3 comments · Fixed by #32302
Closed

ThirdParty E2E framework tests should be [Flaky] in kube 1.4 #32296

derekwaynecarr opened this issue Sep 8, 2016 · 3 comments · Fixed by #32302
Labels
area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@derekwaynecarr
Copy link
Member

ThirdPartyResources (TPR) E2E test creates a custom resource type, and creates an instance of that type in a namespace. The namespace is purged, but the namespace controller DOES NOT observe the dynamic mutation of the type hierarchy. As a result, the instances of that type are never purged, and we could potentially leak resources.

In prior discussions of @kubernetes/sig-api-machinery we agreed that users of TPR would have to kick the namespace controller in the interim in order for it to observe the creation of the new TPR type and have it take part in namespace lifecycle.

If TPR is a priority, we should address the namespace controller issue in kube 1.5, and eliminate the [Flaky] flag from the TPR E2E. The updates in the e2e framework that intropsect the server dynamically to verify all resources are deleted are getting tripped up by the presence of this test and impacting all others.

Here is an example:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/32278/kubernetes-pull-build-test-e2e-gce/57833/

/cc @kubernetes/sig-api-machinery @smarterclayton @lavalamp @brendandburns @ncdc @pwittrock
@derekwaynecarr derekwaynecarr added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 8, 2016
@ncdc
Copy link
Member

ncdc commented Sep 8, 2016

+1 to [Flaky] - this is really causing a ton of flakes

@ncdc
Copy link
Member

ncdc commented Sep 8, 2016

Also note that this doesn't just affect the TPR e2e suite - the existence of the TPR can cause any other e2e suite to fail.

@derekwaynecarr
Copy link
Member Author

/cc @liggitt

@k8s-github-robot k8s-github-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 8, 2016
This was referenced Sep 8, 2016
Merged
Closed
k8s-github-robot pushed a commit that referenced this issue Sep 8, 2016
Merge pull request #32302 from derekwaynecarr/tpr-flaky
986fe3b 
Automatic merge from submit-queue

Mark ThirdParty e2e tests flaky

The root issue:
Fixes #32296

The other related side-effect issues that this should resolve:

Fixes #32237
Fixes #32168
Fixes #32132
Fixes #32122
Fixes #32087
Fixes #32054
Fixes #32053
Fixes #32045
Fixes #32043
Fixes #32025

@lavalamp @pwittrock @ncdc @kubernetes/sig-api-machinery @brendandburns @smarterclayton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark ThirdParty e2e tests flaky derekwaynecarr/kubernetes
3 participants
@ncdc @derekwaynecarr @k8s-github-robot