Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ThirdParty e2e tests flaky #32302

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Sep 8, 2016

The root issue:
Fixes #32296

The other related side-effect issues that this should resolve:

Fixes #32237
Fixes #32168
Fixes #32132
Fixes #32122
Fixes #32087
Fixes #32054
Fixes #32053
Fixes #32045
Fixes #32043
Fixes #32025

@lavalamp @pwittrock @ncdc @kubernetes/sig-api-machinery @brendandburns @smarterclayton


This change is Reviewable

@derekwaynecarr derekwaynecarr added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2016
@derekwaynecarr derekwaynecarr added this to the v1.4 milestone Sep 8, 2016
@ncdc
Copy link
Member

ncdc commented Sep 8, 2016

LGTM

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2016
@derekwaynecarr derekwaynecarr added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 8, 2016
@derekwaynecarr
Copy link
Member Author

I took a pass at the existing namespace failed to delete errors that I could reasonably believe are related to this core issue.

@k8s-bot
Copy link

k8s-bot commented Sep 8, 2016

GCE e2e build/test passed for commit 6218693.

@lavalamp
Copy link
Member

lavalamp commented Sep 8, 2016

LGTM

@lavalamp lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2016
@lavalamp
Copy link
Member

lavalamp commented Sep 8, 2016

@derekwaynecarr can you file (or link) a high priority issue to resolve this and mark these tests non-flaky?

@derekwaynecarr
Copy link
Member Author

@lavalamp -- done #32306

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 986fe3b into kubernetes:master Sep 8, 2016
@pwittrock pwittrock added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2016
foxish added a commit that referenced this pull request Sep 11, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
9 participants