-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socket-based kubelet pod resources API. #70508
Merged
k8s-ci-robot
merged 4 commits into
kubernetes:master
from
dashpole:pod_resources_socket
Nov 15, 2018
Merged
Add socket-based kubelet pod resources API. #70508
k8s-ci-robot
merged 4 commits into
kubernetes:master
from
dashpole:pod_resources_socket
Nov 15, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
kind/feature
Categorizes issue or PR as related to a new feature.
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Oct 31, 2018
k8s-ci-robot
added
area/kubelet
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
labels
Oct 31, 2018
dashpole
force-pushed
the
pod_resources_socket
branch
2 times, most recently
from
October 31, 2018 22:45
8a25e13
to
471dc83
Compare
cc @guptaNswati |
dashpole
force-pushed
the
pod_resources_socket
branch
from
November 1, 2018 00:27
471dc83
to
9ab0430
Compare
k8s-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Nov 1, 2018
dashpole
force-pushed
the
pod_resources_socket
branch
2 times, most recently
from
November 1, 2018 16:32
3cc8627
to
e184c99
Compare
dashpole
force-pushed
the
pod_resources_socket
branch
from
November 1, 2018 17:17
e184c99
to
954fc48
Compare
4 tasks
@vikaschoudhary16 can you take a look? |
dashpole
force-pushed
the
pod_resources_socket
branch
from
November 9, 2018 22:13
954fc48
to
23d67c6
Compare
k8s-ci-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 9, 2018
dashpole
force-pushed
the
pod_resources_socket
branch
from
November 9, 2018 22:39
23d67c6
to
a1dbd5f
Compare
/assign @vikaschoudhary16 @vishh |
dashpole
force-pushed
the
pod_resources_socket
branch
from
November 9, 2018 22:54
a1dbd5f
to
a91dc28
Compare
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Dec 5, 2018
This change introduces kubelt client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Dec 5, 2018
This change introduces kubelt client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Dec 5, 2018
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 3, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 3, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 7, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 8, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 8, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407 Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 8, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407 Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 8, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407 Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 9, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407 Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Jan 9, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: kubernetes/kubernetes#70508 With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407 Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Feb 7, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) With this kubelet service we no longer need to rely on kubelet checkpoint file to get device information. Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Mar 20, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Mar 20, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Mar 20, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Mar 21, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Mar 22, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
ahalimx86
added a commit
to ahalimx86/multus-cni
that referenced
this pull request
Mar 22, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
dougbtv
pushed a commit
to k8snetworkplumbingwg/multus-cni
that referenced
this pull request
Mar 22, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com>
zshi-redhat
pushed a commit
to zshi-redhat/multus-cni
that referenced
this pull request
Mar 22, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com> (cherry picked from commit d3c92b4)
s1061123
pushed a commit
to k8snetworkplumbingwg/multus-cni
that referenced
this pull request
Mar 23, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com> (cherry picked from commit d3c92b4)
zshi-redhat
pushed a commit
to zshi-redhat/multus-cni-1
that referenced
this pull request
Mar 24, 2019
This change introduces kubelet client to get allocated device information of a Pod from newly added Kubelet grpc service. For more information please see: [kubernetes/kubernetes#70508](kubernetes/kubernetes#70508) Change-Id: I11e58ccdd52662601f445fa24c7d55c225441efc Signed-off-by: Abdul Halim <abdul.halim@intel.com> (cherry picked from commit d3c92b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/kubelet
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This introduces a new kubelet socket, which provides read-only information about pods, and serves a grpc service. The initial use-case for this is to support out-of-tree monitoring agents, which need to be able to correlate devices and containers.
Which issue(s) this PR fixes:
Feature Issue: kubernetes/enhancements#606
KEP: kubernetes/community#2454
Special notes for your reviewer:
The API is in
pkg/kubelet/apis/podresources/v1alpha1
.This adds to the device plugin e2e_node test to test its functionality.
cc @RenaudWasTaken @jiayingz @vikaschoudhary16 @vishh @derekwaynecarr
cc @kubernetes/sig-node-api-reviews