New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket-based kubelet pod resources API. #70508

Merged
merged 4 commits into from Nov 15, 2018

Conversation

@dashpole
Copy link
Contributor

dashpole commented Oct 31, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
This introduces a new kubelet socket, which provides read-only information about pods, and serves a grpc service. The initial use-case for this is to support out-of-tree monitoring agents, which need to be able to correlate devices and containers.

Which issue(s) this PR fixes:
Feature Issue: kubernetes/enhancements#606
KEP: kubernetes/community#2454

Special notes for your reviewer:
The API is in pkg/kubelet/apis/podresources/v1alpha1.
This adds to the device plugin e2e_node test to test its functionality.

Add a kubelet socket which serves an grpc service containing the devices used by containers on the node.

cc @RenaudWasTaken @jiayingz @vikaschoudhary16 @vishh @derekwaynecarr
cc @kubernetes/sig-node-api-reviews

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Oct 31, 2018

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch from 471dc83 to 9ab0430 Nov 1, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XL labels Nov 1, 2018

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch 2 times, most recently from 3cc8627 to e184c99 Nov 1, 2018

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch from e184c99 to 954fc48 Nov 1, 2018

@jeremyeder

This comment has been minimized.

Copy link
Member

jeremyeder commented Nov 9, 2018

@vikaschoudhary16 can you take a look?

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch from 954fc48 to 23d67c6 Nov 9, 2018

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/L labels Nov 9, 2018

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch from 23d67c6 to a1dbd5f Nov 9, 2018

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Nov 9, 2018

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch from a1dbd5f to a91dc28 Nov 9, 2018

@dashpole dashpole force-pushed the dashpole:pod_resources_socket branch from b2fc0ca to 630cb53 Nov 15, 2018

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Nov 15, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiayingz

This comment has been minimized.

Copy link
Member

jiayingz commented Nov 15, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 15, 2018

@RenaudWasTaken
Copy link
Member

RenaudWasTaken left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7b4d4bc into kubernetes:master Nov 15, 2018

18 checks passed

cla/linuxfoundation dashpole authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@dashpole dashpole deleted the dashpole:pod_resources_socket branch Nov 15, 2018

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Dec 5, 2018

add kubelet client for Pod resource info
This change introduces kubelt client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Dec 5, 2018

add kubelet client for Pod resource info
This change introduces kubelt client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Dec 5, 2018

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 3, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 3, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 7, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 8, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 8, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <abdul.halim@intel.com>

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 8, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <abdul.halim@intel.com>

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 8, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <abdul.halim@intel.com>

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 9, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <abdul.halim@intel.com>

ahalim-intel added a commit to ahalim-intel/multus-cni that referenced this pull request Jan 9, 2019

add kubelet client for Pod resource info
This change introduces kubelet client to get allocated device
information of a Pod from newly added Kubelet grpc service.
For more information please see:
kubernetes/kubernetes#70508

With this kubelet service we no longer need to rely on kubelet
checkpoint file to get device information.

Change-Id: I3ba098cfea9a0e798f065a4d9b39d0085e125407
Signed-off-by: Abdul Halim <abdul.halim@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment