Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to detect default changes to podspec and podspectemplate defaults #78914

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Add tests to detect default changes to podspec and podspectemplate defaults #78914

merged 1 commit into from
Jun 27, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 11, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Adds unit tests to detect changes to defaults:

  • within PodSpec (which causes spurious container restarts on API server upgrade)
  • within PodSpecTemplate (which causes spurious workload rollouts on API server upgrade)

Which issue(s) this PR fixes:
xref #78904
follow up to (and based on) #78885

Special notes for your reviewer:
Only the second test commit needs reviewing.

Does this PR introduce a user-facing change?:

NONE

/sig apps
/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 11, 2019
@liggitt
Copy link
Member Author

liggitt commented Jun 11, 2019

/milestone v1.16
/priority important-soon

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 11, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 11, 2019
@liggitt
Copy link
Member Author

liggitt commented Jun 11, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 22, 2019

/assign @janetkuo

janetkuo
janetkuo approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits only and LGTM otherwise. Thanks the tests are very thorough.

pkg/apis/core/v1/defaults_test.go Outdated

legacyscheme.Scheme.Default(obj)
defaultedV := visit.value
// t.Log(visit.path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this?

pkg/apis/core/v1/defaults_test.go Outdated
@@ -34,6 +37,280 @@ import (
_ "k8s.io/kubernetes/pkg/api/testapi"
)

// TestWorkloadCompatibility detects changes to defaults within PodTemplateSpec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: TestWorkloadDefaults

@liggitt
Copy link
Member Author

liggitt commented Jun 27, 2019

fixed and tagged

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c8827f into kubernetes:master Jun 27, 2019
@liggitt liggitt deleted the pod-spec-defaults branch June 27, 2019 22:56
@liggitt liggitt mentioned this pull request Mar 3, 2022
Closed
@liggitt liggitt mentioned this pull request May 1, 2023
Merged
@liggitt liggitt mentioned this pull request Dec 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liggitt @k8s-ci-robot @janetkuo