e2e-test.sh should wait for container start #8

jbeda · 2014-06-07T04:27:17Z

Right now the test will assume that when cloudcfg.sh returns the container is up and running. We need to wait until the container is actually running.

jbeda · 2014-06-08T15:05:39Z

@brendandburns put in a 2 min wait here and that may be good enough for now. See: #18. But we should really do something more robust so leaving this bug open.

lavalamp · 2014-06-13T03:04:46Z

This seems like a good excuse to make cloudcfg list pods return more info about the status of containers. Then we could poll that instead of waiting 2 minutes.

brendandburns · 2014-06-16T17:56:12Z

There is now a 'Pending' state, we can add a 'sync' flag to cloudcfg to wait for process startup.

More WIP

derekwaynecarr · 2014-08-01T20:17:47Z

This should be fixed in #704 when it merges.

added missing schema data

WIP: reorganize use cases; add detail

…_pmorie_2 Wire secret registry REST interface into master.

Fixed indents and replaced 'kind' w/ 'resource'. Fixed some more indents. Tests: Replaced kind w/ resource once again, some minor tweaks. Fixed indents. Fixed indents. Only use the API request resolver on actual api prefixed requests. Updated doc for swagger policies. Address gofmt complaints. Consider api prefixes with more than 1 path fragment. ("api/123") Fix: incrementor missing. Refactored and tests added. Allow trailing slash. Addressed kubernetes#3, kubernetes#4, kubernetes#6, kubernetes#5, kubernetes#8, kubernetes#7 Enforce non-resource auth on all users, not only ns'ed. Conflicts: docs/admin/authorization.md pkg/apiserver/handlers_test.go pkg/auth/authorizer/abac/abac_test.go

Fixes messaging on the master unit

Various improvements for kubeadm.

Cherry pick from public: Delete hyper pod via API

Rancher private registry support

Created list of the OpenStack SIG team members.

…ntation Add image POC implementation.

Refactor/rename topo package

* fix bazel issue fix conflict * fix darwin build issue

Ke1289

fix describer tests

…e-fix fix nsenter GetFileType issue in containerized kubelet

* Extend UCPAuthorization for pod parameters Signed-off-by: Alex Mavrogiannis <alex.mavrogiannis@docker.com> * Only allow admins to use fine-grained parameters

Change registry when build hyperkube image

* Extend UCPAuthorization for pod parameters Signed-off-by: Alex Mavrogiannis <alex.mavrogiannis@docker.com> * Only allow admins to use fine-grained parameters

added subnet expiration and renewal tests

Sharing the same connection for multiple streams should have worked, but ran into unexpected timeouts: I0227 08:07:49.754263 80029 portproxy.go:109] container "mock" in pod csi-mock-volumes-4037-2061/csi-mockplugin-0 is running E0227 08:07:49.779359 80029 portproxy.go:178] prepare forwarding csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: dialer failed: unable to upgrade connection: pod not found ("csi-mockplugin-0_csi-mock-volumes-4037-2061") I0227 08:07:50.782705 80029 portproxy.go:109] container "mock" in pod csi-mock-volumes-4037-2061/csi-mockplugin-0 is running I0227 08:07:50.809326 80029 portproxy.go:125] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: starting connection polling I0227 08:07:50.909544 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #0, 0 open I0227 08:07:50.912436 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #0 I0227 08:07:50.912503 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #0 I0227 08:07:50.913161 80029 portproxy.go:322] forward connection #0 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream E0227 08:07:50.913324 80029 portproxy.go:242] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: an error occurred connecting to the remote port: error forwarding port 9000 to pod 66662ea1ab30b4193dac0102c49be840971d337c802cc0c8bbc074214522bd13, uid : failed to execute portforward in network namespace "/var/run/netns/cni-c15e4e36-dad9-8316-c301-33af9dad5717": failed to dial 9000: dial tcp4 127.0.0.1:9000: connect: connection refused I0227 08:07:50.913371 80029 portproxy.go:340] forward connection #0 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side W0227 08:07:50.913487 80029 server.go:669] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams failed to receive the preface from client: EOF" I0227 08:07:51.009519 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #1, 0 open I0227 08:07:51.011912 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #1 I0227 08:07:51.011973 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #1 I0227 08:07:51.013677 80029 portproxy.go:322] forward connection #1 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream I0227 08:07:51.013720 80029 portproxy.go:340] forward connection #1 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side W0227 08:07:51.013794 80029 server.go:669] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams failed to receive the preface from client: EOF" E0227 08:07:51.017026 80029 portproxy.go:242] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: an error occurred connecting to the remote port: error forwarding port 9000 to pod 66662ea1ab30b4193dac0102c49be840971d337c802cc0c8bbc074214522bd13, uid : failed to execute portforward in network namespace "/var/run/netns/cni-c15e4e36-dad9-8316-c301-33af9dad5717": failed to dial 9000: dial tcp4 127.0.0.1:9000: connect: connection refused I0227 08:07:51.109515 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #2, 0 open I0227 08:07:51.111479 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #2 I0227 08:07:51.111519 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #2 I0227 08:07:51.209519 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #3, 1 open I0227 08:07:51.766305 80029 csi.go:377] gRPC call: {"Method":"/csi.v1.Identity/Probe","Request":{},"Response":{"ready":{"value":true}},"Error":"","FullError":null} I0227 08:07:51.768304 80029 csi.go:377] gRPC call: {"Method":"/csi.v1.Identity/GetPluginInfo","Request":{},"Response":{"name":"csi-mock-csi-mock-volumes-4037","vendor_version":"0.3.0","manifest":{"url":"https://k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock"}},"Error":"","FullError":null} I0227 08:07:51.770494 80029 csi.go:377] gRPC call: {"Method":"/csi.v1.Identity/GetPluginCapabilities","Request":{},"Response":{"capabilities":[{"Type":{"Service":{"type":1}}},{"Type":{"VolumeExpansion":{"type":1}}},{"Type":{"Service":{"type":2}}}]},"Error":"","FullError":null} I0227 08:07:51.772899 80029 csi.go:377] gRPC call: {"Method":"/csi.v1.Controller/ControllerGetCapabilities","Request":{},"Response":{"capabilities":[{"Type":{"Rpc":{"type":1}}},{"Type":{"Rpc":{"type":3}}},{"Type":{"Rpc":{"type":10}}},{"Type":{"Rpc":{"type":4}}},{"Type":{"Rpc":{"type":6}}},{"Type":{"Rpc":{"type":5}}},{"Type":{"Rpc":{"type":8}}},{"Type":{"Rpc":{"type":7}}},{"Type":{"Rpc":{"type":12}}},{"Type":{"Rpc":{"type":11}}},{"Type":{"Rpc":{"type":9}}}]},"Error":"","FullError":null} I0227 08:08:21.209901 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating error stream: Timeout occurred I0227 08:08:21.209980 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #3, 1 open I0227 08:08:51.211522 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating data stream: Timeout occurred I0227 08:08:51.211566 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #3, 1 open I0227 08:08:51.213451 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #3 I0227 08:08:51.213498 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #3 I0227 08:08:51.309540 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #4, 2 open I0227 08:08:52.215358 80029 portproxy.go:322] forward connection #3 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream I0227 08:08:52.215475 80029 portproxy.go:340] forward connection #3 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side I0227 08:09:21.310003 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating error stream: Timeout occurred I0227 08:09:21.310086 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #4, 1 open I0227 08:09:51.311854 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating data stream: Timeout occurred I0227 08:09:51.311908 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #4, 1 open I0227 08:09:51.314415 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #4 I0227 08:09:51.314497 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #4 I0227 08:09:51.409527 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #5, 2 open I0227 08:09:52.326203 80029 portproxy.go:322] forward connection #4 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream I0227 08:09:52.326277 80029 portproxy.go:340] forward connection #4 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side I0227 08:10:21.409892 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating error stream: Timeout occurred I0227 08:10:21.409954 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #5, 1 open I0227 08:10:51.411455 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating data stream: Timeout occurred I0227 08:10:51.411557 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #5, 1 open I0227 08:10:51.413229 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #5 I0227 08:10:51.413274 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #5 I0227 08:10:51.509508 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #6, 2 open I0227 08:10:52.414862 80029 portproxy.go:322] forward connection #5 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream I0227 08:10:52.414931 80029 portproxy.go:340] forward connection #5 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side I0227 08:11:21.509879 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating error stream: Timeout occurred I0227 08:11:21.509934 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #6, 1 open I0227 08:11:51.511519 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating data stream: Timeout occurred I0227 08:11:51.511568 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #6, 1 open I0227 08:11:51.513519 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #6 I0227 08:11:51.513571 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #6 I0227 08:11:51.609504 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #7, 2 open I0227 08:11:52.517799 80029 portproxy.go:322] forward connection #6 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream I0227 08:11:52.517918 80029 portproxy.go:340] forward connection #6 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side I0227 08:12:21.609856 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating error stream: Timeout occurred I0227 08:12:21.609909 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #7, 1 open I0227 08:12:51.611494 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating data stream: Timeout occurred I0227 08:12:51.611555 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #7, 1 open I0227 08:12:51.613289 80029 portproxy.go:155] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: created a new connection #7 I0227 08:12:51.613343 80029 portproxy.go:286] forward listener for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: got a new connection #7 I0227 08:12:51.709535 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #8, 2 open I0227 08:12:52.615858 80029 portproxy.go:322] forward connection #7 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: remote side closed the stream I0227 08:12:52.615989 80029 portproxy.go:340] forward connection #7 for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: closing our side W0227 08:12:52.616116 80029 server.go:669] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams failed to receive the preface from client: EOF" I0227 08:13:21.709934 80029 portproxy.go:151] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: no connection: error creating error stream: Timeout occurred I0227 08:13:21.709997 80029 portproxy.go:148] port forwarding for csi-mock-volumes-4037-2061/csi-mockplugin-0:9000: trying to create a new connection #8, 1 open Feb 27 08:13:30.916: FAIL: Failed to register CSIDriver csi-mock-csi-mock-volumes-4037 Unexpected error: <*errors.errorString | 0xc002666220>: { s: "error waiting for CSI driver csi-mock-csi-mock-volumes-4037 registration on node kind-worker2: timed out waiting for the condition", } error waiting for CSI driver csi-mock-csi-mock-volumes-4037 registration on node kind-worker2: timed out waiting for the condition occurred

…lusters-1.22 HACK: misc hacks for transparent sharded list/watch

Add create handler and refactor

Manually merged. Misclick just now...

fix: allow non system:master users to create/update rbac

…klink_fix_1.24 Use golang library instead of mklink

jbeda added bug labels Jun 7, 2014

pmorie referenced this issue in pmorie/kubernetes Jul 24, 2014

Merge pull request #8 from ncdc/build-poc

3068a85

More WIP

brendandburns closed this as completed Aug 8, 2014

jwhonce pushed a commit to jwhonce/kubernetes that referenced this issue Dec 18, 2014

Merge pull request kubernetes#8 from markturansky/pd_dev

fe36397

added missing schema data

pmorie referenced this issue in pmorie/kubernetes Jan 30, 2015

Merge pull request #8 from pmorie/secrets_proposal

2c3b33c

WIP: reorganize use cases; add detail

EricMountain-1A pushed a commit to EricMountain-1A/kubernetes that referenced this issue Feb 10, 2015

Merge pull request kubernetes#8 from EricMountain-1A/secrets_proposal…

49fa530

…_pmorie_2 Wire secret registry REST interface into master.

lazypower pushed a commit to lazypower/kubernetes that referenced this issue Sep 7, 2016

Merge pull request kubernetes#8 from chuckbutler/master-messaging-fix

d7c2c5f

Fixes messaging on the master unit

yoojinl pushed a commit to yoojinl/kubernetes that referenced this issue Sep 16, 2016

Merge pull request kubernetes#8 from luxas/kubeadm

0bdba2b

Various improvements for kubeadm.

resouer pushed a commit to resouer/kubernetes that referenced this issue Sep 20, 2016

Merge pull request kubernetes#8 from feiskyer/cherry-pick-rm-pod

08a2669

Cherry pick from public: Delete hyper pod via API

joshwget pushed a commit to joshwget/kubernetes that referenced this issue Sep 20, 2016

Merge pull request kubernetes#8 from alena1108/privateregistry

7cab572

Rancher private registry support

xingzhou pushed a commit to xingzhou/kubernetes that referenced this issue Dec 15, 2016

Merge pull request kubernetes#8 from idvoretskyi/patch-1

44e74f3

Created list of the OpenStack SIG team members.

vriesmarcel mentioned this issue Mar 9, 2017

DNS resolving does not work on windows nodes #42605

Closed

Random-Liu pushed a commit to Random-Liu/kubernetes that referenced this issue Mar 16, 2017

Merge pull request kubernetes#8 from Random-Liu/add-image-poc-impleme…

64318f1

…ntation Add image POC implementation.

0xmichalis mentioned this issue Apr 11, 2017

client-go workqueue example #44320

Merged

ConnorDoyle referenced this issue in ConnorDoyle/kubernetes Jul 14, 2017

Merge pull request #8 from sjenning/refactor-topo

e426775

Refactor/rename topo package

andyzhangx added a commit to andyzhangx/kubernetes that referenced this issue Sep 25, 2017

fix bazel issue (kubernetes#8)

16d49c7

* fix bazel issue fix conflict * fix darwin build issue

andyzhangx added a commit to andyzhangx/kubernetes that referenced this issue Oct 10, 2017

fix bazel issue (kubernetes#8)

e912889

* fix bazel issue fix conflict * fix darwin build issue

shyamjvs mentioned this issue Nov 27, 2017

Refactor retry logic away from updateCIDRAllocation() #56352

Merged

cofyc added a commit to cofyc/kubernetes that referenced this issue Jan 8, 2018

Merge pull request kubernetes#8 from cofyc/ke1289

f3db3ad

Ke1289

k8s-github-robot pushed a commit that referenced this issue May 25, 2018

Merge pull request #8 from deads2k/juan-02

34167b6

fix describer tests

tossmilestone added a commit to tossmilestone/kubernetes that referenced this issue Jul 13, 2018

Merge pull request kubernetes#8 from tossmilestone/nsenter-getfiletyp…

25a0ba9

…e-fix fix nsenter GetFileType issue in containerized kubelet

LiuQIu7 mentioned this issue Oct 25, 2018

kube-proxy call iptables-save or iptables-restore cause kernel panic periodly #70229

Closed

KubeStacker pushed a commit to KubeStacker/kubernetes that referenced this issue Dec 21, 2018

Merge pull request kubernetes#8 from es-container/es-v1.9.8

2ba02d6

Change registry when build hyperkube image

jsafrane mentioned this issue May 27, 2019

Volume Scheduling Limits #77595

Merged

saschagrunert mentioned this issue Jan 29, 2021

Switch to docker buildx for conformance image #98569

Merged

b3atlesfan pushed a commit to b3atlesfan/kubernetes that referenced this issue Feb 5, 2021

Merge pull request kubernetes#8 from eyakubovich/master

5f7c262

added subnet expiration and renewal tests

dims mentioned this issue Feb 19, 2021

Differentiate build process for non-amd platforms #82778

Merged

liggitt mentioned this issue May 10, 2021

Deprecate and remove DynamicKubeletConfig (?) #100799

Closed

mtaufen mentioned this issue Jun 18, 2021

deprecate and disable by default DynamicKubeletConfig feature flag #102966

Merged

stevekuznetsov pushed a commit to stevekuznetsov/kubernetes that referenced this issue Nov 16, 2021

Merge pull request kubernetes#8 from stevekuznetsov/feature-logical-c…

bcabd0d

…lusters-1.22 HACK: misc hacks for transparent sharded list/watch

imzhengwei mentioned this issue Mar 1, 2023

ERROR: process "/bin/sh -c setcap cap_net_bind_service=+ep /${BINARY}" #116168

Closed

wm775825 pushed a commit to wm775825/kubernetes that referenced this issue Dec 6, 2023

Merge pull request kubernetes#8 from wm775825/release-1.28

ea6c041

Add create handler and refactor

linxiulei pushed a commit to linxiulei/kubernetes that referenced this issue Jan 18, 2024

Merge pull request kubernetes#8 from Random-Liu/fix-godeps

cce6b46

Manually merged. Misclick just now...

wm775825 pushed a commit to wm775825/kubernetes that referenced this issue Jan 19, 2024

Merge pull request kubernetes#8 from wm775825/bugfix-wm-rbac

6ddc045

fix: allow non system:master users to create/update rbac

haitch added a commit to haitch/kubernetes that referenced this issue Mar 9, 2024

Merge pull request kubernetes#8 from aks-lts/haitao/windows_kubelet_m…

8ef884a

…klink_fix_1.24 Use golang library instead of mklink

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

e2e-test.sh should wait for container start #8

e2e-test.sh should wait for container start #8

jbeda commented Jun 7, 2014

jbeda commented Jun 8, 2014

lavalamp commented Jun 13, 2014

brendandburns commented Jun 16, 2014

derekwaynecarr commented Aug 1, 2014

e2e-test.sh should wait for container start #8

e2e-test.sh should wait for container start #8

Comments

jbeda commented Jun 7, 2014

jbeda commented Jun 8, 2014

lavalamp commented Jun 13, 2014

brendandburns commented Jun 16, 2014

derekwaynecarr commented Aug 1, 2014