Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off apiserver deprecated metrics #83837

Merged
merged 2 commits into from Nov 17, 2019
Merged

Turn off apiserver deprecated metrics #83837

merged 2 commits into from Nov 17, 2019

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Oct 12, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Turn off metrics that have been deprecated.

Refer to kubernetes/enhancements#1206:

Kubernetes 1.17 will remove the in 1.14 marked as deprecated metrics. As a stretch goal, if the metrics stability framework is in place, then in Kubernetes 1.17 the metrics will only be turned off by default through the stability framework. Should this not be available, then the metrics will be removed.

Which issue(s) this PR fixes:
Part of kubernetes/enhancements#1206

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Following metrics have been turned off:
- apiserver_request_count
- apiserver_request_latencies
- apiserver_request_latencies_summary
- apiserver_dropped_requests
- etcd_request_latencies_summary
- apiserver_storage_transformation_latencies_microseconds
- apiserver_storage_data_key_generation_latencies_microseconds
- apiserver_storage_transformation_failures_total

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/da4b7050ccae7a947e4d60f94ab28513e513a458/keps/sig-instrumentation/20181106-kubernetes-metrics-overhaul.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 12, 2019
@RainbowMango
Copy link
Member Author

/retest

@BenTheElder BenTheElder mentioned this pull request Oct 13, 2019
Merged
@RainbowMango
Copy link
Member Author

Sorry to bother you. Maybe this triggered a potential bug, I need to investigate more.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019
This was referenced Oct 14, 2019
Closed
Merged
@timothysc timothysc removed their request for review October 14, 2019 21:17
@fedebongio
Copy link
Contributor

/assign @logicalhan

@RainbowMango
Copy link
Member Author

Rely on #84135. Let's continue after that.

@RainbowMango RainbowMango force-pushed the pr_hide_apiserver_deprecated_metrics branch from e180f2d to 1f8c07e Compare November 11, 2019 11:32
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2019
@RainbowMango
Copy link
Member Author

/retest

@RainbowMango RainbowMango mentioned this pull request Nov 11, 2019
Merged
@RainbowMango
Copy link
Member Author

Retry after kubernetes/perf-tests#893 (That might not help for this PR, but let's try again)

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

@RainbowMango
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@RainbowMango
Copy link
Member Author

/hold cancel
/priority important-soon
/assign @smarterclayton
/milestone v1.17
/cc @brancz @logicalhan

@kubernetes/sig-api-machinery-pr-reviews
I hope it in v1.17.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 14, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 14, 2019
@RainbowMango
Copy link
Member Author

/cc @krzysied @BenTheElder for e2e framework.

@RainbowMango
Copy link
Member Author

Maybe @liggitt can help put it in v1.17. :)

oomichi
oomichi reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e framework part seems good for me.

/approve

test/e2e/framework/metrics/interesting_metrics.go
// TODO(krzysied): apiserver_request_latencies_summary is a deprecated metric.
// It should be replaced with new metric.
"apiserver_request_latencies_summary",
"apiserver_request_latency_seconds",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems good for me because of
apiserver_request_latencies_summary -> apiserver_request_latency_seconds as https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.14.md#deprecated-metrics

@oomichi
Copy link
Member

oomichi commented Nov 14, 2019

/cc @oomichi

@smarterclayton
Copy link
Contributor

I will approve if you can get a lgtm from Frederic or another instrumentation reviewer

@logicalhan
Copy link
Member

I will approve if you can get a lgtm from Frederic or another instrumentation reviewer

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@brancz
Copy link
Member

brancz commented Nov 14, 2019

/lgtm

@josiahbjorgaard
Copy link
Contributor

@smarterclayton Do you have what you need to approve here?

@RainbowMango RainbowMango mentioned this pull request Nov 15, 2019
Closed
@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, RainbowMango, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit beaf3a2 into kubernetes:master Nov 17, 2019
@RainbowMango RainbowMango deleted the pr_hide_apiserver_deprecated_metrics branch November 18, 2019 07:30
@RainbowMango RainbowMango mentioned this pull request Nov 19, 2019
Closed
@RainbowMango RainbowMango mentioned this pull request Nov 27, 2019
Merged
@daxmc99 daxmc99 mentioned this pull request Mar 13, 2020
Closed
@tosi3k tosi3k mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@brancz brancz Awaiting requested review from brancz

@logicalhan logicalhan Awaiting requested review from logicalhan

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@logicalhan logicalhan

@smarterclayton smarterclayton

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@RainbowMango @fedebongio @jeefy @oomichi @smarterclayton @logicalhan @brancz @josiahbjorgaard @k8s-ci-robot