Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #85444: Provided a mechanism to re-register hidden metrics. #85627

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Automated cherry pick of #85444: Provided a mechanism to re-register hidden metrics. #85627

merged 1 commit into from
Nov 28, 2019

Conversation

RainbowMango
Copy link
Member

Cherry pick of #85444 on release-1.17.

#85444: Provided a mechanism to re-register hidden metrics.

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 26, 2019
@RainbowMango
Copy link
Member Author

/assign @logicalhan
cc @liggitt @dims

@tpepper
Copy link
Member

tpepper commented Nov 26, 2019

/kind bug
/priority critical-urgent
from parent PR

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 26, 2019
@tpepper
Copy link
Member

tpepper commented Nov 26, 2019

Across the set of:

It is unclear to me if this is just bug fixing and required for 1.17, or actually part of the enhancement which didn't fully correctly land in 1.17 and perhaps not actually a good candidate for cherry picking.

Would appreciate a summary of status and recommendation from @RainbowMango @dims @dashpole @derekwaynecarr.

/cc @mrbobbytables @guineveresaenger

@RainbowMango
Copy link
Member Author

@tpepper
This is indeed a bug fix and required for 1.17.
We have turned off, the behavior is hidden, some metrics from kube-apiserver(#83837) and also provided a command-line flag (#84292) to enable the hidden metrics. The two things already in release-1.17. But for some reason, part of these metrics can not be enabled. So we need this patch for 1.17.

@dims
Copy link
Member

dims commented Nov 28, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2019
@justaugustus
Copy link
Member

/assign @logicalhan @brancz

logicalhan
logicalhan approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@justaugustus
Copy link
Member

Release Managers approval:
/lgtm
/approve

@justaugustus justaugustus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, logicalhan, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a53fc65 into kubernetes:release-1.17 Nov 28, 2019
@RainbowMango RainbowMango deleted the automated-cherry-pick-of-#85444-upstream-release-1.17 branch November 28, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@coffeepac coffeepac Awaiting requested review from coffeepac

@serathius serathius Awaiting requested review from serathius

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@dims dims

@justaugustus justaugustus

@logicalhan logicalhan

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
7 participants
@RainbowMango @tpepper @dims @justaugustus @k8s-ci-robot @logicalhan @brancz